perf: duplicate getSchedule request#17191
Merged
keithwillcode merged 3 commits intomainfrom Oct 20, 2024
Merged
Conversation
dosubot
bot
added
the
performance
keithwillcode
added
core
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/19/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
commented
Oct 20, 2024
| isTeamEvent?: boolean; | ||
| } = {}) => { | ||
| const { timezone } = useTimePreferences(); | ||
| const event = useEvent({ fromRedirectOfNonOrgLink }); |
Contributor
Author
There was a problem hiding this comment.
we are already using useEvent hook in the parent component.
Udit-takkar
commented
Oct 20, 2024
| rescheduleUid, | ||
| month: monthFromStore ?? month, | ||
| duration: durationFromStore ?? duration, | ||
| isTeamEvent: pathname?.indexOf("/team/") !== -1 || isTeam, |
Contributor
Author
There was a problem hiding this comment.
This was causing duplicate request of getSchedule. isTeam was intially false but later it was calculated to be true for team event types
Udit-takkar
commented
Oct 20, 2024
| return { | ||
| props: { | ||
| entity: eventData.entity, | ||
| eventTypeId: eventData.id, |
Contributor
Author
There was a problem hiding this comment.
just pass the eventTypeId from getServersideProps to prevent waiting for it to load in public.event query and execute slots.getSchedule as soon as we can with the correct input
dosubot
bot
added
the
bookings
hbjORbj
approved these changes
Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before:-
After:-
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?