fix: change order of eventtypes and routingforms

[vijayraghav-io]

What does this PR do?

• Fixes [CAL-4568] add new routers and event-types to the top, not the bottom #17614
• Fixes CAL-4568

/claim #17614

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• - N/A -I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

[vercel]

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/13/24)

1 label was added to this PR based on Keith Williams's automation.

[Praashh]

LGTM!!

[vijayraghav-io]

@PeerRich , updated for eventTypes, routingForms, workflows.
Bookings already have sort as per the tab.

cal.com/packages/lib/bookings/getAllUserBookings.ts

Lines 110 to 114 in 1aac70f

	upcoming: { startTime: "asc" },
	recurring: { startTime: "asc" },
	past: { startTime: "desc" },
	cancelled: { startTime: "desc" },
	unconfirmed: { startTime: "asc" },

As of now, I couldn't find anything more to be included.
Please let know if any more entities to be included.

[github-actions]

E2E results are ready!

• Workflow #39038.1 latest results

[vijayraghav-io]

@Praashh , all tests are passing. you can approve again

[Praashh]

@Praashh , all tests are passing. you can approve again

let me give it a final touch.

[Praashh]

LGTM!! thank you so much @vijayraghav-io

[keithwillcode]

@vijayraghav-io @Praashh Just double-checking we are sure there aren't pieces of code that depend on the sort order for some reason?

(Marking requested changes just to block merging first)

[vijayraghav-io]

@vijayraghav-io @Praashh Just double-checking we are sure there aren't pieces of code that depend on the sort order for some reason?

Hi @keithwillcode , double checked again that - the sole purpose of these updated (sort order) functions is to ultimately render the lists <li in UI through trpc handlers/endpoints. Verified that these functions have no references or are not called anywhere else.
Also there is no dependency on sort order in the UI for these entities.

[keithwillcode]

@vijayraghav-io @Praashh Just double-checking we are sure there aren't pieces of code that depend on the sort order for some reason?

Hi @keithwillcode , double checked again that - the sole purpose of these updated (sort order) functions is to ultimately render the lists <li in UI through trpc handlers/endpoints. Verified that these functions have no references or are not called anywhere else. Also there is no dependency on sort order in the UI for these entities.

Great. Thanks, @vijayraghav-io

Vijay addressed concern

[vijayraghav-io]

Thank you! @keithwillcode 🙏

[vijayraghav-io]

updated due to changes after #17689 was merged

[vijayraghav-io]

Added a new test - to ensure new eventType added will be first in the list

[Praashh]

We also need a test case for the routing form.

[Praashh]

Great Work @vijayraghav-io sir, LGTM!!!