Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot read properties of undefined (reading 'timeZone') #18107

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: Cannot read properties of undefined (reading 'timeZone') #18107

merged 3 commits into from
Jan 7, 2025

Conversation

Praashh
Copy link
Contributor

@Praashh Praashh commented Dec 11, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [] I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team December 11, 2024 11:40
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 11, 2024
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking consumer emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Dec 11, 2024
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Dec 11, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 11, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/11/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/01/25)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode mentioned this pull request Dec 11, 2024
Closed
3 tasks
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 3:56am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 3:56am

Udit-takkar
Udit-takkar reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this would just fix the type error but we should figure out why timeZone is missing from organizer or attendee.

This could mess up the availability checking, event creation, etc. if there is no timezone attached and we use default one

@Praashh
Copy link
Contributor Author

Praashh commented Dec 12, 2024

Well this would just fix the type error but we should figure out why timeZone is missing from organizer or attendee.

This could mess up the availability checking, event creation, etc. if there is no timezone attached and we use default one

yeah agreed, I'll check/fix this 🙏

@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 27, 2024
hariombalhara
hariombalhara previously approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! But I have one concern that how come attendees[0] could be undefined, there is something else wrong beyond this fn I think.

It might be a good idea to add an explicit comment on why there is a fallback for attendees[0].timeZone

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025 •
edited
Loading

E2E results are ready!

@github-actions github-actions bot removed the Stale label Jan 2, 2025
@hariombalhara hariombalhara enabled auto-merge (squash) January 7, 2025 03:58
@hariombalhara hariombalhara merged commit 6178092 into main Jan 7, 2025
39 checks passed
@hariombalhara hariombalhara deleted the fix/unfined_timezone_calEvent branch January 7, 2025 04:17
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@Praashh @hariombalhara @MuhammadAimanSulaiman
fix: Cannot read properties of undefined (reading 'timeZone') (calcom…
eb5bed5 
…#18107)

Co-authored-by: Hariom <hariombalhara@gmail.com>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@Praashh @hariombalhara @MuhammadAimanSulaiman
fix: Cannot read properties of undefined (reading 'timeZone') (calcom…
5956f57 
…#18107)

Co-authored-by: Hariom <hariombalhara@gmail.com>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@Praashh @hariombalhara @MuhammadAimanSulaiman
fix: Cannot read properties of undefined (reading 'timeZone') (calcom…
a1215b0 
…#18107)

Co-authored-by: Hariom <hariombalhara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs consumer emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'timeZone')
4 participants
@Praashh @hariombalhara @Udit-takkar @keithwillcode