chore: app router - /reschedule pages #18150
Merged
+7
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/13/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
hbjORbj
added
high-risk
hbjORbj
commented
Dec 18, 2024
| import { headers, cookies } from "next/headers"; | ||
|
|
||
| import { buildLegacyCtx } from "@lib/buildLegacyCtx"; | ||
| import { getServerSideProps } from "@lib/reschedule/[uid]/getServerSideProps"; | ||
|
|
||
| export const generateMetadata = async () => |
There was a problem hiding this comment.
The metadata generation would never be used since the user will be redirected before the page renders.
hbjORbj
added
ready-for-e2e
and removed
high-risk
hbjORbj
added a commit
that referenced
this pull request
Dec 18, 2024
hbjORbj
added a commit
that referenced
this pull request
Dec 19, 2024
* app router - /reschedule pages * add to config.matcher * generateMetdata is not needed
hbjORbj
added a commit
that referenced
this pull request
Dec 19, 2024
* app router - /reschedule pages * add to config.matcher * generateMetdata is not needed
hbjORbj
added a commit
that referenced
this pull request
Dec 19, 2024
…schedule pages to App Router (#18261) * chore: app router - /reschedule pages (#18150) * app router - /reschedule pages * add to config.matcher * generateMetdata is not needed * include app directory in rewrites generation logic * make it more readable * make code more elegant * fix * fix * fix * fix * test and refactor
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
* app router - /reschedule pages * add to config.matcher * generateMetdata is not needed
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Jan 10, 2025
…schedule pages to App Router (calcom#18261) * chore: app router - /reschedule pages (calcom#18150) * app router - /reschedule pages * add to config.matcher * generateMetdata is not needed * include app directory in rewrites generation logic * make it more readable * make code more elegant * fix * fix * fix * fix * test and refactor
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
* app router - /reschedule pages * add to config.matcher * generateMetdata is not needed
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 20, 2025
…schedule pages to App Router (calcom#18261) * chore: app router - /reschedule pages (calcom#18150) * app router - /reschedule pages * add to config.matcher * generateMetdata is not needed * include app directory in rewrites generation logic * make it more readable * make code more elegant * fix * fix * fix * fix * test and refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tested
Screen.Recording.2024-12-17.at.11.19.15.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/reschedule/[uid]