Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: app router - /teams single page #18184

Merged
merged 2 commits into from
Dec 18, 2024
Merged

chore: app router - /teams single page #18184

merged 2 commits into from
Dec 18, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 14, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4895

Tested

Screenshot 2024-12-17 at 11 53 16

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@linear Linear
Copy link

linear bot commented Dec 14, 2024

CAL-4895 Remove Pages Router / Render App Router `/teams` single page

@graphite-app graphite-app bot requested a review from a team December 14, 2024 18:13
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 14, 2024
@dosubot dosubot bot added the teams area: teams, round robin, collective, managed event-types label Dec 14, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 14, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj marked this pull request as draft December 14, 2024 18:20
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 6:58pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 6:58pm

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review December 17, 2024 16:51
emrysal
emrysal approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one works for me locally.

@emrysal emrysal merged commit 0a7a0e3 into main Dec 18, 2024
41 checks passed
@emrysal emrysal deleted the chore/app-router-teams branch December 18, 2024 17:51
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: app router - /teams single page (calcom#18184)
209f706 
* chore: app router - /teams single page

* fix type check
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: app router - /teams single page (calcom#18184)
bc51258 
* chore: app router - /teams single page

* fix type check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @emrysal @keithwillcode