Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Salesforce tests to getContacts method #18225

Merged
merged 3 commits into from
Jan 7, 2025
Merged

chore: Add Salesforce tests to getContacts method #18225

merged 3 commits into from
Jan 7, 2025

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Dec 17, 2024 •
edited
Loading

What does this PR do?

  • Adds more tests to the getContacts method
    • Tests are split between when no params are passed, includeOwner is passed, and forRoundRobinSkip is passed
  • When no owner is found still return the contacts

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot requested a review from a team December 17, 2024 05:28
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid labels Dec 17, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 17, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 17, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@joeauyeung joeauyeung changed the title chore: Add Salesforce tests chore: Add Salesforce tests to getContacts method Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@Udit-takkar Udit-takkar added this to the v4.9 milestone Dec 17, 2024
Udit-takkar
Udit-takkar reviewed Dec 17, 2024
View reviewed changes
packages/app-store/salesforce/lib/CrmService.ts
return records
.map((record) => {
if (!record?.Id || !record?.OwnerId) {
if (!record?.Id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure here that OwnerId property would be set?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@zomars zomars merged commit 79d51a4 into main Jan 7, 2025
63 of 84 checks passed
@zomars zomars deleted the salesforce-add-more-tests branch January 7, 2025 21:14
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@joeauyeung @MuhammadAimanSulaiman
chore: Add Salesforce tests to getContacts method (calcom#18225)
8ae8795
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@joeauyeung @MuhammadAimanSulaiman
chore: Add Salesforce tests to getContacts method (calcom#18225)
c6fa860
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@joeauyeung @MuhammadAimanSulaiman
chore: Add Salesforce tests to getContacts method (calcom#18225)
a4f1640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@zomars zomars zomars approved these changes

Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ready-for-e2e Stale
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
4 participants
@joeauyeung @zomars @Udit-takkar @keithwillcode