Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add TLD in username of managed users #18229

Merged
merged 4 commits into from
Dec 17, 2024
Merged

chore: add TLD in username of managed users #18229

merged 4 commits into from
Dec 17, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Dec 17, 2024 •
edited
Loading

What does this PR do?

adding Top Level Domain to managed users username to avoid conflicts

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A- I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

yarn test:e2e

@dosubot dosubot bot added the teams area: teams, round robin, collective, managed event-types label Dec 17, 2024
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Dec 17, 2024
@graphite-app graphite-app bot requested a review from a team December 17, 2024 09:08
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 17, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (12/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:12am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:12am

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@ThyMinimalDev ThyMinimalDev merged commit c7dc3ec into main Dec 17, 2024
39 checks passed
@ThyMinimalDev ThyMinimalDev deleted the add-tld-in-managed-user-username branch December 17, 2024 10:45
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@ThyMinimalDev @MuhammadAimanSulaiman
chore: add TLD in username of managed users (calcom#18229)
e292d0a 
* chore: add TLD in username of managed users

* fixup! chore: add TLD in username of managed users

* bump platform libraries
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
@ThyMinimalDev @MuhammadAimanSulaiman
chore: add TLD in username of managed users (calcom#18229)
350de4b 
* chore: add TLD in username of managed users

* fixup! chore: add TLD in username of managed users

* bump platform libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supalarry supalarry supalarry approved these changes

Assignees
No one assigned
Labels
core area: core, team members only platform Anything related to our platform plan ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThyMinimalDev @supalarry @keithwillcode