fix: single rejection caused cache cron to fail

[zomars]

What does this PR do?

follow up to #18237 #18224

This pull request includes changes to improve the handling of calendar subscriptions and simplify the repository code. The most important changes include modifying the way promises are handled in the handleCalendarsToWatch function, removing unnecessary feature repository checks, and updating the SelectedCalendarRepository class.

Improvements to calendar subscription handling:

• packages/features/calendar-cache/api/cron.ts: Changed from using Promise.all to Promise.allSettled for handling calendar watch and unwatch operations, and simplified the response object by removing detailed success/failure counts.

Codebase simplification:

• packages/lib/server/repository/selectedCalendar.ts: Removed the import and usage of FeaturesRepository and the associated feature check for "calendar-cache", simplifying the conditions for unwatching subscriptions. [1] [2] [3]

• Fixes #XXXX (GitHub issue number)
• Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Are there environment variables that should be set?
• What are the minimal test data to have?
• What is expected (happy path) to have (input and output)?
• Any other important info that could help to test that PR

Checklist

• I haven't read the contributing guide
• My code doesn't follow the style guidelines of this project
• I haven't commented my code, particularly in hard-to-understand areas
• I haven't checked if my changes generate no new warnings

[graphite-app]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[github-actions]

E2E results are ready!

• Workflow #41698.1 latest results