Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match edit user sheet designs #18243

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Dec 18, 2024

What does this PR do?

Matches the designs we have for the edit sheet

Fixes: CAL-4090

Figma: https://www.figma.com/design/UajFu4M1APhn2AywAEJkJr/New-Features?node-id=22357-446870&t=zd6MgRF445X7rbNQ-4

We can match 1-1 to the way attributes is proposed here without changing FE and BE logic and that felt like more issue than what it was worth for this tiny issue

Screenies:
CleanShot 2024-12-18 at 10 39 55
CleanShot 2024-12-18 at 10 40 57

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Open edit members sheet

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team December 18, 2024 10:41
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 18, 2024
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 18, 2024
Copy link

graphite-app bot commented Dec 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/18/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link

linear bot commented Dec 18, 2024

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks ok to me

@emrysal emrysal enabled auto-merge (squash) December 18, 2024 11:30
@emrysal emrysal merged commit 34b0753 into main Dec 18, 2024
60 of 81 checks passed
@emrysal emrysal deleted the feat/match-edit-sheet-designs branch December 18, 2024 11:50
Copy link
Contributor

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
* edit sheet design changes

* remove attribute header
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
* edit sheet design changes

* remove attribute header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants