Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed posthog identifier #18253

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore: removed posthog identifier #18253

merged 1 commit into from
Dec 18, 2024

Conversation

nizzyabi
Copy link
Contributor

What does this PR do?

This PR removes unneeded posthog files and disables the identification of user profiles.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • [Y] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [Y] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [Y] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Console & Network tab

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "removed posthog identifier". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added the core area: core, team members only label Dec 18, 2024
@graphite-app graphite-app bot requested a review from a team December 18, 2024 17:06
Copy link

graphite-app bot commented Dec 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title removed posthog identifier chore: removed posthog identifier Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

E2E results are ready!

@nizzyabi nizzyabi merged commit b56824e into main Dec 18, 2024
59 of 81 checks passed
@nizzyabi nizzyabi deleted the posthog-identifier-fix branch December 18, 2024 20:03
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants