Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bring back removed onboarding steps #18254

Merged
merged 4 commits into from
Dec 18, 2024
Merged

chore: bring back removed onboarding steps #18254

merged 4 commits into from
Dec 18, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 18, 2024 •
edited
Loading

What does this PR do?

  • Bring back connected-calendar and connected-video steps for onboarding flow because we decided that this is better UX

Tested

tt.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go through the onboarding flow using Google auth

@hbjORbj hbjORbj enabled auto-merge (squash) December 18, 2024 17:30
@graphite-app graphite-app bot requested a review from a team December 18, 2024 17:30
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 18, 2024
@hbjORbj hbjORbj marked this pull request as draft December 18, 2024 17:31
auto-merge was automatically disabled December 18, 2024 17:31

Pull request was converted to draft

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:20pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:20pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review December 18, 2024 18:17
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 18, 2024
@hbjORbj hbjORbj enabled auto-merge (squash) December 18, 2024 18:22
@hbjORbj hbjORbj merged commit b4fd6f3 into main Dec 18, 2024
38 checks passed
@hbjORbj hbjORbj deleted the chore/bring-back-removed-onboarding-steps branch December 18, 2024 19:05
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: bring back removed onboarding steps (calcom#18254)
97fd0c5 
* add connected-calendar and connected-video steps back

* adapt test

* fix name
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: bring back removed onboarding steps (calcom#18254)
a923ed5 
* add connected-calendar and connected-video steps back

* adapt test

* fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright consumer core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @PeerRich @keithwillcode