Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize useCustomTemplate state based on payloadTemplate prop… #18257

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: initialize useCustomTemplate state based on payloadTemplate prop… #18257

merged 1 commit into from
Jan 6, 2025

Conversation

Akashjayan1999
Copy link
Contributor

… in WebhookForm

What does this PR do?

Fix:
https://www.loom.com/share/782de7eba6fa421aac2cdc8899bab842?sid=27b07241-0a0b-44dd-a52d-ce697377014d

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024

@Akashjayan1999 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 18, 2024
@graphite-app graphite-app bot requested a review from a team December 18, 2024 20:14
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input webhooks area: webhooks, callback, webhook payload 🐛 bug Something isn't working labels Dec 18, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 18, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/18/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/29/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh self-assigned this Dec 19, 2024
Praashh
Praashh reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-19 at 4 08 10 PM

it's working fine, can you share steps to reproduce it🙏 .

@Akashjayan1999
Copy link
Contributor Author

https://www.loom.com/share/5e1ded72853d4755bb1ce6a26cef6ad3
Here is the Loom video that demonstrates how to reproduce this error.

Praashh
Praashh approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@PeerRich PeerRich merged commit f7f3697 into calcom:main Jan 6, 2025
54 of 79 checks passed
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@Akashjayan1999 @MuhammadAimanSulaiman
fix: initialize useCustomTemplate state based on payloadTemplate prop… (
bf5a0fe 
calcom#18257)
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@Akashjayan1999 @MuhammadAimanSulaiman
fix: initialize useCustomTemplate state based on payloadTemplate prop… (
f7fe97d 
calcom#18257)
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@Akashjayan1999 @MuhammadAimanSulaiman
fix: initialize useCustomTemplate state based on payloadTemplate prop… (
90cc09b 
calcom#18257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh approved these changes

Assignees

@Praashh Praashh

Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input webhooks area: webhooks, callback, webhook payload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-4925] Custom payload input not showing in webhook
3 participants
@Akashjayan1999 @Praashh @PeerRich