Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Last used label in button shown in 2-factor code and backup screen #18341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asadath1395
Copy link
Contributor

@asadath1395 asadath1395 commented Dec 22, 2024

What does this PR do?

Last used label in button shown in 2-factor code and backup screen. Ideally it should be shown only in the first screen to indicate user what they used before, it doesn't make sense to show in 2-factor code and backup screen

Issue:

Screen.Recording.2024-12-22.at.11.43.14.AM.mov

After fix:

Screen.Recording.2024-12-22.at.11.48.16.AM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Login and setup 2-factor auth
  • Logout and check the Last Used label in Sign in button and 2-factor code and backup screen

Copy link

vercel bot commented Dec 22, 2024

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team December 22, 2024 06:18
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 22, 2024
@dosubot dosubot bot added authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in 🐛 bug Something isn't working labels Dec 22, 2024
Copy link

graphite-app bot commented Dec 22, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/22/24)

1 label was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in 🐛 bug Something isn't working community Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant