Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Route Builder field input looses focus on typing #18381

Merged
merged 6 commits into from
Dec 27, 2024
Merged

fix: Route Builder field input looses focus on typing #18381

merged 6 commits into from
Dec 27, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Dec 27, 2024 •
edited
Loading

What does this PR do?

Fixes the issue mentioned here

This Loom shows it working

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot requested a review from a team December 27, 2024 04:07
@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix routing form field input loosing focus on typing". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hariombalhara hariombalhara changed the title Fix routing form field input loosing focus on typing fix: Routing form field input looses focus on typing Dec 27, 2024
@dosubot dosubot bot added routing-forms area: routing forms, routing, forms 🐛 bug Something isn't working labels Dec 27, 2024
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Dec 27, 2024
@hariombalhara hariombalhara changed the title fix: Routing form field input looses focus on typing fix: Route Builder field input looses focus on typing Dec 27, 2024
hariombalhara
hariombalhara commented Dec 27, 2024
View reviewed changes
packages/app-store/routing-forms/__tests__/uiConfig.test.ts
expect(result2.widgets.text.factory).toBe(textFactory);
});

it("should reuse same component fns for settings - ensures remounting is not happening", () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test ensures regression doesn't occur

@hariombalhara hariombalhara force-pushed the fix-routing-form-input-component-remounting-on-change branch from 155a514 to 1a7f2d6 Compare December 27, 2024 04:10
@vercel Vercel
Copy link

vercel bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 7:07am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 7:07am

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 27, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Udit-takkar
Udit-takkar previously approved these changes Dec 27, 2024
View reviewed changes
@Udit-takkar Udit-takkar enabled auto-merge (squash) December 27, 2024 06:26
@hariombalhara
fix ts error
c3db5a2
@hariombalhara
Merge remote-tracking branch 'origin/main' into fix-routing-form-inpu…
964ff31 
…t-component-remounting-on-change
@hariombalhara
Merge branch 'fix-routing-form-input-component-remounting-on-change' …
4f41ead 
…of github.com:calcom/cal.com into fix-routing-form-input-component-remounting-on-change
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@Udit-takkar Udit-takkar merged commit ab942ed into main Dec 27, 2024
38 checks passed
@Udit-takkar Udit-takkar deleted the fix-routing-form-input-component-remounting-on-change branch December 27, 2024 09:00
joeauyeung pushed a commit that referenced this pull request Jan 5, 2025
@hariombalhara @Udit-takkar @joeauyeung
Fix routing form field input loosing focus on typing (#18381)
12808c5 
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@hariombalhara @Udit-takkar @MuhammadAimanSulaiman
Fix routing form field input loosing focus on typing (calcom#18381)
39d5301 
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 20, 2025
@hariombalhara @Udit-takkar @MuhammadAimanSulaiman
Fix routing form field input loosing focus on typing (calcom#18381)
b5b4992 
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e routing-forms area: routing forms, routing, forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariombalhara @Udit-takkar @keithwillcode