fix: improve App Store filters & misaligned arrow indicators #18455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy in view on mount
|
@cnhhoang850 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
app-store
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/03/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/03/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/03/25)1 label was added to this PR based on Keith Williams's automation. |
cnhhoang850
changed the title
E2E results are ready! |
Praashh
suggested changes
Jan 3, 2025
Done ty |
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 24, 2025
…dy in view on mount (calcom#18455)
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 24, 2025
…dy in view on mount (calcom#18455)
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
…dy in view on mount (calcom#18455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change filtering logic from sever side to client side in All apps display in App Store to improve interactivity & performance. Current implementation freezes without interaction indication due to routing & resets page position.
Aligned arrow indicators with width of filters category tab bar
Before
https://www.loom.com/share/1c9e5309941d42498b399a63c83d4cc7
fix_.make.App.Store.filter.logic.client.side.misaligned.arrow.indicators.-.Old.mp4
After
https://www.loom.com/share/445f188a12a14455895f8b5d60cf4653
fix_.make.App.Store.filter.logic.client.side.misaligned.arrow.indicators.-.New.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?