Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase Tasker queue limit to 1000 #18482

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

zomars
Copy link
Member

@zomars zomars commented Jan 6, 2025

What does this PR do?

Reduces the chance of Tasker queue being clogged. This could be the reason for some tasks to be delayed up to 15 minutes to run.

This pull request includes a change to the Task class in the packages/features/tasker/repository.ts file. The change increases the limit of tasks retrieved from 100 to 1000.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team January 6, 2025 22:18
@dosubot dosubot bot added the 🐛 bug Something isn't working label Jan 6, 2025
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 6, 2025
Copy link

graphite-app bot commented Jan 6, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/06/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

E2E results are ready!

@Udit-takkar Udit-takkar added this to the v4.9 milestone Jan 7, 2025
@Udit-takkar
Copy link
Contributor

@zomars should we also re add cleanup method in Task repository to remove successfully executed tasks from 1 or 2 months back?

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 10:53am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 10:53am

@keithwillcode keithwillcode merged commit b6c6fa7 into main Jan 7, 2025
37 checks passed
@keithwillcode keithwillcode deleted the fix/increase-tasker-queue-limit branch January 7, 2025 11:10
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants