Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make it easier to manage group options and also improve attribute options performance with 100s of options #18486

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: Make it easier to manage group options and also improve attribute options performance with 100s of options #18486

merged 3 commits into from
Jan 7, 2025

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Jan 7, 2025 •
edited
Loading

What does this PR do?

Now:
image

Before:
image

Detailed Changes:

  • Reverses the group and option relationship in UI
  • Added some missing texts
  • Cleaned up the code
  • Added tests as it is a critical piece

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Add remove options and option groups

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Make it easier to manage perf and also improve perf". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 7, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 10:31am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 10:31am

@hariombalhara hariombalhara force-pushed the improve-perf-make-it-easier-to-manage-groups branch from 66e6fb5 to 7afe28e Compare January 7, 2025 08:32
@hariombalhara hariombalhara force-pushed the improve-perf-make-it-easier-to-manage-groups branch from 7afe28e to 4d7ab0d Compare January 7, 2025 08:40
@hariombalhara hariombalhara changed the title Make it easier to manage perf and also improve perf fix: Make it easier to manage group options and also improve attribute options performance with 100s of options Jan 7, 2025
@hariombalhara hariombalhara marked this pull request as ready for review January 7, 2025 08:48
@graphite-app graphite-app bot requested a review from a team January 7, 2025 08:48
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jan 7, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 7, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/07/25)

1 label was added to this PR based on Keith Williams's automation.

@hariombalhara hariombalhara force-pushed the improve-perf-make-it-easier-to-manage-groups branch from 4d7ab0d to bdd7295 Compare January 7, 2025 09:17
@hariombalhara hariombalhara force-pushed the improve-perf-make-it-easier-to-manage-groups branch from bdd7295 to 72eea4b Compare January 7, 2025 10:30
emrysal
emrysal approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, lgtm 👍

@hariombalhara hariombalhara enabled auto-merge (squash) January 7, 2025 11:05
@hariombalhara hariombalhara merged commit 2e9beb8 into main Jan 7, 2025
58 of 59 checks passed
@hariombalhara hariombalhara deleted the improve-perf-make-it-easier-to-manage-groups branch January 7, 2025 11:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@hariombalhara @MuhammadAimanSulaiman
fix: Make it easier to manage group options and also improve attribut…
647f8fd 
…e options performance with 100s of options (calcom#18486)
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@hariombalhara @MuhammadAimanSulaiman
fix: Make it easier to manage group options and also improve attribut…
35cf291 
…e options performance with 100s of options (calcom#18486)
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@hariombalhara @MuhammadAimanSulaiman
fix: Make it easier to manage group options and also improve attribut…
40e027b 
…e options performance with 100s of options (calcom#18486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariombalhara @emrysal @keithwillcode