Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused layouts: MainLayout & MainLayoutAppDir #18498

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 7, 2025

What does this PR do?

  • Remove MainLayout & MainLayoutAppDir
  • Left a self-review

Tested

Screenshot 2025-01-07 at 6 42 05 AM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jan 7, 2025 11:42am
calcom-web-canary ⬜️ Ignored (Inspect) Jan 7, 2025 11:42am

@graphite-app graphite-app bot requested a review from a team January 7, 2025 11:42
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 7, 2025
@dosubot dosubot bot added enterprise area: enterprise, audit log, organisation, SAML, SSO foundation labels Jan 7, 2025
@hbjORbj hbjORbj changed the title chore: remove unused layouts chore: remove unused layouts: MainLayout & MainLayoutAppDir Jan 7, 2025
@@ -42,7 +42,7 @@ export default function EnterprisePage() {
];
return (
<div>
<ShellMain heading={t("enterprise")} subtitle={t("enterprise_description")}>
<Shell heading={t("enterprise")} subtitle={t("enterprise_description")}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnterprisePage was basically doing

When it just could do

@@ -1,17 +0,0 @@
"use client";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the only instance this was used is in app/enterprise/page.tsx

@@ -1,17 +0,0 @@
import type { ComponentProps } from "react";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this isn't used anywhere

Copy link

graphite-app bot commented Jan 7, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

E2E results are ready!

@emrysal emrysal merged commit 0c69c5d into main Jan 7, 2025
49 of 88 checks passed
@emrysal emrysal deleted the chore/remove-unused-layouts branch January 7, 2025 12:13
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants