Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add index to AssignmentReason #18520

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: add index to AssignmentReason #18520

merged 1 commit into from
Jan 8, 2025

Conversation

eunjae-lee
Copy link
Contributor

What does this PR do?

The table AssignmentReason is mostly queried along with bookingId. This PR adds an index for it.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Checklist

@graphite-app graphite-app bot requested a review from a team January 8, 2025 10:00
@github-actions github-actions bot added the ❗️ migrations contains migration files label Jan 8, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 8, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 8, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/08/25)

1 label was added to this PR based on Keith Williams's automation.

@eunjae-lee
Copy link
Contributor Author

Not sure about "Codacy Static Code Analysis".

What's wrong with this change, and what do to?
Screenshot 2025-01-08 at 11 17 23

emrysal
emrysal approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd think the foreign index would be added automatically. Ignore codacy, doesn't work great on migrations

@emrysal emrysal enabled auto-merge (squash) January 8, 2025 11:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

E2E results are ready!

@emrysal emrysal merged commit b941b71 into main Jan 8, 2025
59 of 81 checks passed
@emrysal emrysal deleted the fix/assignment-reason-index branch January 8, 2025 12:32
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@eunjae-lee @MuhammadAimanSulaiman
fix: add index to AssignmentReason (calcom#18520)
63f65f5
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
@eunjae-lee @MuhammadAimanSulaiman
fix: add index to AssignmentReason (calcom#18520)
2db599e
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@eunjae-lee @MuhammadAimanSulaiman
fix: add index to AssignmentReason (calcom#18520)
a2fd6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ migrations contains migration files ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @emrysal @keithwillcode