Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Webhook should timeout fast on e2e #18570

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

zomars
Copy link
Member

@zomars zomars commented Jan 9, 2025

What does this PR do?

The are some test that hang on waiting for web hook that never comes. Immediate webhooks should not take more than 5 seconds IMO.

This pull request includes changes to the createHttpServer function in the apps/web/playwright/lib/testUtils.ts file to improve the handling of request count waiting and add a timeout mechanism.

Improvements to request count handling:

  • Modified the waitForRequestCount function to include a resolved flag to track if the promise has been resolved.
  • Added a timeout mechanism that rejects the promise with an error if the request count is not met within 5 seconds.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team January 9, 2025 23:03
@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Jan 9, 2025
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 9, 2025
Copy link

graphite-app bot commented Jan 9, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/09/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

E2E results are ready!

@keithwillcode keithwillcode merged commit 3adb8e8 into main Jan 9, 2025
43 of 82 checks passed
@keithwillcode keithwillcode deleted the chore/webhook-e2e-timeouts branch January 9, 2025 23:52
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 24, 2025
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants