feat: Add cancelledBy input to cancellation page#18770
feat: Add cancelledBy input to cancellation page#18770anikdhabal merged 17 commits intocalcom:mainfrom
Conversation
|
@iharsh02 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/20/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/20/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (07/14/25)1 label was added to this PR based on Keith Williams's automation. |
|
@Praashh sorry for the last PR , what happened their was not suppose to happen truly embarrassing 🙏 |
Praashh
left a comment
There was a problem hiding this comment.
LGTM! tagging @anikdhabal for a final touch..
|
This PR is being marked as stale due to inactivity. |
|
@iharsh02 thanks for your work. Could you pls fix the conflicts |
|
@anikdhabal fixed the merge conflicts 🙏 |
|
@iharsh02 Pls resolve the conflicts and address the cubic comments. |
There was a problem hiding this comment.
cubic found 1 issue across 3 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
This reverts commit 2838053.
|
Reverted the pr for now, because tests are failing in many prs. We need to handle the tests along with this. @iharsh02 let's fix it the whole thing in a follow-up pr. |
The tests are failing because they’re not configured to handle the cancellation dialog box. @anikdhabal, could you take a look at this? Also, please let me know if you’d like me to proceed further with this PR. |
|
yes @iharsh02 pls go ahead |
* feat: Add cancelledBy input to cancellation page * fix: Update email verification error message * Update safe-parse.ts * fix: check attendees and booking owner email * fix: minor ui * Update CancelBooking.tsx * Update common.json --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Kartik Saini <41051387+kart1ka@users.noreply.github.com>
|
@anikdhabal fixed the test would you like me to make another PR ?
|

What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
cal-5045.mp4