Skip to content

fix: modify error handling of incompleteBookingWriteToRecord#18998

Merged
emrysal merged 3 commits intomainfrom
chore/update-error-states-of-incomplete-bookings
Jan 29, 2025
Merged

fix: modify error handling of incompleteBookingWriteToRecord#18998
emrysal merged 3 commits intomainfrom
chore/update-error-states-of-incomplete-bookings

Conversation

@emrysal
Copy link
Contributor

@emrysal emrysal commented Jan 29, 2025

What does this PR do?

  • DON'T throw error when personRecord is not found in Salesforce (email does not exist in CRM, unrecoverable)
  • DO throw error when personRecord update fails (for any reason) - we need to know.

@emrysal emrysal requested a review from joeauyeung January 29, 2025 16:22
@graphite-app graphite-app bot requested a review from a team January 29, 2025 16:22
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 29, 2025
@dosubot dosubot bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid 🐛 bug Something isn't working labels Jan 29, 2025
joeauyeung
joeauyeung previously approved these changes Jan 29, 2025
@graphite-app
Copy link

graphite-app bot commented Jan 29, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/29/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/29/25)

1 label was added to this PR based on Keith Williams's automation.

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 4:45pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 4:45pm

@github-actions
Copy link
Contributor

E2E results are ready!

@emrysal emrysal merged commit b6a7a8f into main Jan 29, 2025
39 checks passed
@emrysal emrysal deleted the chore/update-error-states-of-incomplete-bookings branch January 29, 2025 17:12
emrysal added a commit that referenced this pull request Jan 29, 2025
* fix: modify error handling of incompleteBookingWriteToRecord

* fix: TS error?

* fix: TS error attempt #2?
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
…18998)

* fix: modify error handling of incompleteBookingWriteToRecord

* fix: TS error?

* fix: TS error attempt #2?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid foundation ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants