-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intl-number-format #19390
base: main
Are you sure you want to change the base?
feat: intl-number-format #19390
Conversation
@TusharBhatt1 is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/19/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/19/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (02/21/25)1 label was added to this PR based on Keith Williams's automation. |
…att1/cal.com into feat/intl_number_format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding a few unit tests to ensure function behave as expected.
Agreed with @youneshenniwrites - formatNumberByLocale seems to be useful not only with TextField I reckon. |
True , added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What does this PR do?
Before :
After :
Mandatory Tasks (DO NOT REMOVE)