Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intl-number-format #19390

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

TusharBhatt1
Copy link
Contributor

What does this PR do?

Before :

Screenshot (129)

After :

Screenshot (130)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Feb 19, 2025

@TusharBhatt1 is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 19, 2025
@graphite-app graphite-app bot requested a review from a team February 19, 2025 19:20
@github-actions github-actions bot added routing-forms area: routing forms, routing, forms ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "feat/intl-number-format". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Feb 19, 2025
@dosubot dosubot bot added the i18n area: i18n, translations label Feb 19, 2025
Copy link

graphite-app bot commented Feb 19, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/19/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/19/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/21/25)

1 label was added to this PR based on Keith Williams's automation.

@TusharBhatt1 TusharBhatt1 changed the title add : intl-numberformat feat/intl_number_format Feb 19, 2025
@TusharBhatt1 TusharBhatt1 changed the title feat/intl_number_format feat/intl-number-format Feb 19, 2025
@TusharBhatt1 TusharBhatt1 changed the title feat/intl-number-format feat: intl-number-format Feb 19, 2025
Copy link
Contributor

@youneshenniwrites youneshenniwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a few unit tests to ensure function behave as expected.

@emrysal
Copy link
Contributor

emrysal commented Feb 20, 2025

Agreed with @youneshenniwrites - formatNumberByLocale seems to be useful not only with TextField I reckon.

@TusharBhatt1
Copy link
Contributor Author

Agreed with @youneshenniwrites - formatNumberByLocale seems to be useful not only with TextField I reckon.

True , added tests

@PeerRich PeerRich requested a review from emrysal February 21, 2025 12:58
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs ✨ feature New feature or request i18n area: i18n, translations 🧹 Improvements Improvements to existing features. Mostly UX/UI ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ready-for-e2e routing-forms area: routing forms, routing, forms ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5189] format number inputs based on browser use Intl.NumberFormat
5 participants