Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: webhook cancellation reason #19840

Closed

Conversation

skmanoj322
Copy link

What does this PR do?

Visual Demo (For contributors especially)

cal_webhook_feature.mp4

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Payload

same as cancel webhook just added reason for cancellation

{"triggerEvent":"BOOKING_CANCELLATION_REASON","createdAt":"2025-03-07T12:19:44.475Z","payload":{"bookerUrl":"https://3000-calcom-calcom-ocwfolg42h9.ws-us118.gitpod.io","title":"test webhook between delete-me and delete-me","length":15,"type":"test-webhook","description":"testing","customInputs":{},"eventTypeId":1149,"userFieldsResponses":{},"responses":{"name":{"label":"name","value":"delete-me"},"email":{"label":"email","value":"delete-me@example.com"},"notes":{"label":"notes","value":"testing"},"guests":{"label":"guests","value":[]}},"startTime":"2025-03-07T14:45:00+00:00","endTime":"2025-03-07T15:00:00+00:00","organizer":{"id":1,"username":"delete-me","email":"delete-me@example.com","name":"delete-me","timeZone":"Europe/London","timeFormat":"h:mma","language":{"locale":"en"},"utcOffset":0},"attendees":[{"name":"delete-me","email":"delete-me@example.com","timeZone":"Asia/Calcutta","phoneNumber":null,"language":{"locale":"en"},"utcOffset":330}],"uid":"kJgMBN5Jdojhkrww4r7j5h","bookingId":32,"location":"integrations:daily","destinationCalendar":[],"cancellationReason":"test Cancellation","seatsPerTimeSlot":null,"seatsShowAttendees":false,"iCalUID":"kJgMBN5Jdojhkrww4r7j5h@Cal.com","iCalSequence":1,"eventTitle":"test webhook","eventDescription":null,"requiresConfirmation":null,"price":null,"currency":"usd","status":"CANCELLED","cancelledBy":"delete-me@example.com"}}

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

just create webhook of and cancel the event

@skmanoj322 skmanoj322 requested a review from a team as a code owner March 7, 2025 14:09
Copy link

vercel bot commented Mar 7, 2025

@skmanoj322 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ TusharBhatt1
❌ skmanoj322
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 7, 2025
@graphite-app graphite-app bot requested a review from a team March 7, 2025 14:09
@github-actions github-actions bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid webhooks area: webhooks, callback, webhook payload ✨ feature New feature or request ❗️ migrations contains migration files and removed ✨ feature New feature or request webhooks area: webhooks, callback, webhook payload crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "webhook cancellation reason". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the webhooks area: webhooks, callback, webhook payload label Mar 7, 2025
@dosubot dosubot bot added this to the v5.1 milestone Mar 7, 2025
Copy link

graphite-app bot commented Mar 7, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/07/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions github-actions bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request labels Mar 8, 2025
@skmanoj322 skmanoj322 changed the title webhook cancellation reason feat: webhook cancellation reason Mar 8, 2025
Copy link
Contributor

@TusharBhatt1 TusharBhatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skmanoj322
Copy link
Author

@TusharBhatt1 can you provide the context for these

@TusharBhatt1
Copy link
Contributor

@TusharBhatt1 can you provide the context for these
these ?

@TusharBhatt1 TusharBhatt1 enabled auto-merge (squash) March 11, 2025 14:22
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @skmanoj322, I think there was a misunderstanding with the issue. This didn’t ask for a new webhook; we only want to add the cancellation reason to the existing cancel webhook's payload

Sorry about that! We’ll try to make it clearer next time. 🙏

@TusharBhatt1
Copy link
Contributor

Thanks for the effort , closing this.
@skmanoj322 feel free to raise a new one with the approach @CarinaWolli mentioned above.

auto-merge was automatically disabled March 11, 2025 15:27

Pull request was closed

@dosubot dosubot bot modified the milestone: v5.1 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request ❗️ migrations contains migration files webhooks area: webhooks, callback, webhook payload
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5239] cancellation reason: webhook and salesforce
4 participants