perf: Remove data fetching in metadata for non-booking pages #20734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
performance
hbjORbj
commented
Apr 16, 2025
| if (!parsed.success) { | ||
| notFound(); | ||
| } | ||
| const workflow = await getWorkflow(parsed.data.workflow); |
There was a problem hiding this comment.
Data fetching for metadata isn't optimal. Below is enough.
await _generateMetadata(
(t) => t("workflows"),
(t) => t("workflows_to_automate_notifications")
);
hbjORbj
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/16/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
commented
Apr 16, 2025
| import { _generateMetadata } from "app/_utils"; | ||
| import type { ReactNode } from "react"; | ||
|
|
||
| export const generateMetadata = async () => |
There was a problem hiding this comment.
this is now used for both /workflows and /workflows/[workflow] page
E2E results are ready! |
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
Apr 16, 2025
| export const generateMetadata = async ({ params, searchParams }: PageProps) => { | ||
| const legacyCtx = buildLegacyCtx(await headers(), await cookies(), await params, await searchParams); | ||
|
|
||
| const { appMetadata } = await getData(legacyCtx); |
hbjORbj
commented
Apr 16, 2025
| @@ -23,7 +23,6 @@ const normalizePages = (pages: string[] | string | undefined) => { | |||
| export const generateMetadata = async ({ params }: { params: Promise<{ pages: string[] }> }) => { | |||
| const { mainPage } = normalizePages((await params).pages); | |||
| return await _generateMetadata( | |||
| // TODO: Need to show the actual form name instead of "Form" | |||
There was a problem hiding this comment.
nope, keeping it the current way is better
zomars
previously approved these changes
Apr 18, 2025
|
@zomars Had to resolve conflicts. Can you re-approve? 🙏 |
zomars
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tfunction for i18n)Before OG image
15-minute Reminder is the name of the workflow
After OG image
/workflows/[id]page now has this metadata:Mandatory Tasks (DO NOT REMOVE)
How should this be tested?