perf: server-side-data-fetching-for-workflows #20773
Conversation
|
@TusharBhatt1 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
keithwillcode
added
the
community-interns
dosubot
bot
added
performance
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/19/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (04/19/25)1 label was added to this PR based on Keith Williams's automation. |
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
TusharBhatt1
changed the title
| import WorkflowList from "../components/WorkflowListPage"; | ||
|
|
||
| type PageProps = { | ||
| filteredList?: Awaited<ReturnType<typeof WorkflowRepository.getFilteredList>>; | ||
| hasValidLicense: boolean; |
There was a problem hiding this comment.
We are not using filteredList anywhere here
There was a problem hiding this comment.
can you elaborate on what you mean?
There was a problem hiding this comment.
FilteringList is just defined neither passed nor used
| ); | ||
| const _searchParams = await searchParams; | ||
| const context = buildLegacyCtx(await headers(), await cookies(), await params, _searchParams); | ||
| const session = await getSession(context); |
There was a problem hiding this comment.
Q: Is getSession working correctly? I know this is being used in a few places, but I am not sure if it's working properly. We should getServerSession more often. Can you test?
There was a problem hiding this comment.
Checked ! Works well
| import WorkflowList from "../components/WorkflowListPage"; | ||
|
|
||
| type PageProps = { | ||
| filteredList?: Awaited<ReturnType<typeof WorkflowRepository.getFilteredList>>; | ||
| hasValidLicense: boolean; |
There was a problem hiding this comment.
can you elaborate on what you mean?
…//github.com/TusharBhatt1/cal.com into perf/server-side-data-fetching-for-/webflows
| </div> | ||
| ); | ||
| }; | ||
|
|
What does this PR do?
This PR moves data fetching for /workflows to server side, improving performance and load times.
Visual Demo (For contributors especially)
Before and after :
workflows.mp4
Mandatory Tasks (DO NOT REMOVE)