Skip to content

fix: multiple button designs of dropdown#21928

Merged
anikdhabal merged 2 commits intocalcom:mainfrom
Adarsh9977:cal/dropdown-button
Jun 19, 2025
Merged

fix: multiple button designs of dropdown#21928
anikdhabal merged 2 commits intocalcom:mainfrom
Adarsh9977:cal/dropdown-button

Conversation

@Adarsh9977
Copy link
Contributor

@Adarsh9977 Adarsh9977 commented Jun 19, 2025

What does this PR do?

This PR fixes the design of last button of dropwown

Visual Demo (For contributors especially)

  • Before
Screenshot 2025-06-19 at 7 49 46 PM
  • After
Screenshot 2025-06-19 at 7 21 25 PM
  • This is only one Image for overview

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Fixed inconsistent border radius on the last button in dropdown menus to match design guidelines.

@vercel
Copy link

vercel bot commented Jun 19, 2025

@Adarsh9977 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2025

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 19, 2025
@graphite-app graphite-app bot requested a review from a team June 19, 2025 14:20
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Jun 19, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 6 files and found no issues. Review PR in cubic.dev.

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@graphite-app
Copy link

graphite-app bot commented Jun 19, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/19/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (06/19/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (06/19/25)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal enabled auto-merge (squash) June 19, 2025 14:41
@anikdhabal anikdhabal merged commit 00aac89 into calcom:main Jun 19, 2025
30 of 35 checks passed
@github-actions
Copy link
Contributor

E2E results are ready!

BKM14 pushed a commit to BKM14/cal.com that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments