Skip to content

Comments

perf: remove one server fetch (me fetcher) in /teams#22444

Merged
hbjORbj merged 4 commits intomainfrom
refactor/remove-me-from-teams
Jul 15, 2025
Merged

perf: remove one server fetch (me fetcher) in /teams#22444
hbjORbj merged 4 commits intomainfrom
refactor/remove-me-from-teams

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jul 12, 2025

What does this PR do?

Refactored the teams components to remove direct user ("me") fetching, simplifying props and logic by using organization ID and admin status instead.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Covered by existing tests

@graphite-app graphite-app bot requested a review from a team July 12, 2025 06:41
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jul 12, 2025
@vercel
Copy link

vercel bot commented Jul 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 10:04pm
cal-eu ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 10:04pm

@dosubot dosubot bot added teams area: teams, round robin, collective, managed event-types 💻 refactor labels Jul 12, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot previously approved these changes Jul 12, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 4 files and found no issues. Review PR in cubic.dev.

@delve-auditor
Copy link

delve-auditor bot commented Jul 12, 2025

No security or compliance issues detected. Reviewed everything up to aa8ebac.

Security Overview
  • 🔎 Scanned files: 6 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hbjORbj hbjORbj changed the title refactor: remove me from teams perf: remove one server fetch (me fetcher) in /teams Jul 12, 2025
@hbjORbj hbjORbj requested a review from emrysal July 12, 2025 06:44
@graphite-app
Copy link

graphite-app bot commented Jul 12, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/12/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/12/25)

1 label was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj enabled auto-merge (squash) July 12, 2025 06:45
@hbjORbj hbjORbj disabled auto-merge July 12, 2025 06:45
@hbjORbj hbjORbj enabled auto-merge (squash) July 12, 2025 06:45
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2025

E2E results are ready!

emrysal
emrysal previously approved these changes Jul 12, 2025
@hbjORbj hbjORbj dismissed stale reviews from emrysal and cubic-dev-ai[bot] via 5223876 July 15, 2025 21:10
@hbjORbj hbjORbj requested a review from a team as a code owner July 15, 2025 21:10
@vercel vercel bot temporarily deployed to Preview – api July 15, 2025 21:10 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Walkthrough

The changes refactor how organization and user role information is accessed and propagated across several components and layouts. Instead of passing and relying on a full user object, the code now extracts the organization ID and role directly from the session or user profile, with fallback logic to ensure robustness. Components such as TeamsListing, TeamList, and TeamListItem have been updated to accept orgId and, where necessary, a boolean indicating admin or owner status, replacing prior usage of the user object. The logic for determining admin or owner privileges is now centralized using a utility function and enhanced with fallback checks. No exported function signatures have been removed; only prop types and internal logic were updated.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/layout.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/web/app/(use-page-wrapper)/(main-nav)/teams/server-page.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/web/app/(use-page-wrapper)/settings/organizations/(org-admin-only)/layout.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5223876 and aa8ebac.

📒 Files selected for processing (3)
  • apps/web/app/(use-page-wrapper)/(main-nav)/teams/server-page.tsx (2 hunks)
  • apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/layout.tsx (1 hunks)
  • apps/web/app/(use-page-wrapper)/settings/organizations/(org-admin-only)/layout.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/(org-admin-only)/layout.tsx
  • apps/web/app/(use-page-wrapper)/settings/organizations/(org-admin-only)/layout.tsx
  • apps/web/app/(use-page-wrapper)/(main-nav)/teams/server-page.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Install dependencies / Yarn install & cache
  • GitHub Check: Security Check
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel vercel bot temporarily deployed to Preview – api July 15, 2025 22:04 Inactive
@hbjORbj hbjORbj merged commit e6da5c8 into main Jul 15, 2025
85 of 90 checks passed
@hbjORbj hbjORbj deleted the refactor/remove-me-from-teams branch July 15, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only foundation ready-for-e2e 💻 refactor teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants