fix: improve restriction schedule description#22517
Conversation
WalkthroughThis update modifies the English localization key and description for the restriction schedule feature, simplifying its explanation. In the event availability tab component, the description key for the restriction schedule toggle was updated and a trailing space was removed from a class name string. The toggle’s rendering condition remains unchanged. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-playwright". (The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
dosubot
bot
added
event-types
|
✅ No security or compliance issues detected. Reviewed everything up to 3575282. Security Overview
Detected Code Changes
Reply to this PR with |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
apps/web/public/static/locales/en/common.json (1)
3265-3266: Localizations missing key migrationThe old key
choose_restriction_schedule_descriptionis still defined in every non-English locale file, so the UI will fall back to a raw string for those languages. You need to remove the deprecated key and add the two new keys with appropriate translations in each pack before merging.• Affected files:
apps/web/public/static/locales/*/common.json (all language folders)
• Actions required:
– Delete the"choose_restriction_schedule_description"entry in each file
– Add the new keys with corresponding translations:
•"choose_restriction_schedule": "<translation>"
•"restriction_schedule_description": "<translation>"Ensure consistency across all locale files before merging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/public/static/locales/en/common.json(1 hunks)packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: bandhan-majumder
PR: calcom/cal.com#22359
File: packages/lib/server/locales/en/common.json:1336-1339
Timestamp: 2025-07-14T16:31:45.201Z
Learning: When making localization changes for new features, it's often safer to add new strings rather than modify existing ones to avoid breaking existing functionality that depends on the original strings. This approach allows for feature-specific customization while maintaining backward compatibility.
apps/web/public/static/locales/en/common.json (1)
undefined
<retrieved_learning>
Learnt from: bandhan-majumder
PR: #22359
File: packages/lib/server/locales/en/common.json:1336-1339
Timestamp: 2025-07-14T16:31:45.201Z
Learning: When making localization changes for new features, it's often safer to add new strings rather than modify existing ones to avoid breaking existing functionality that depends on the original strings. This approach allows for feature-specific customization while maintaining backward compatibility.
</retrieved_learning>
🧬 Code Graph Analysis (1)
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx (2)
apps/api/v2/src/modules/auth/guards/organization-roles/organization-roles.guard.ts (1)
isPlatform(40-45)packages/ui/components/form/index.ts (1)
SettingsToggle(36-36)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Security Check
🔇 Additional comments (2)
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx (2)
669-669: Minor cleanup: Trailing space removed.Good cleanup removing the trailing space from the className string.
854-854: Localization key updated to match simplified description.The description key has been changed from
"choose_restriction_schedule_description"to"restriction_schedule_description", which aligns with the PR objective to provide a clearer and more concise description.Based on the retrieved learnings, when making localization changes, it's often safer to add new strings rather than modify existing ones to avoid breaking functionality. However, since this appears to be a deliberate simplification as mentioned in the PR objectives, this change looks appropriate.
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx
Outdated
Show resolved
Hide resolved
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/15/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (07/15/25)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
3 participants
What does this PR do?
Before:
After:
Summary by CodeRabbit
Style
Documentation