fix: 400 is correct error code for computing slot for past booking

[hbjORbj]

What does this PR do?

Problem: getSchedule.handler.ts returns 500 error code for BookingDateInPastError.

The flow is:

getSchedule API endpoint
  ↓
getScheduleHandler
  ↓
availableSlotsService.getAvailableSlots()
  ↓
_getAvailableSlots()
  ↓
_mapWithinBoundsSlotsToDate()
  ↓
isTimeOutOfBounds

isTimeOutOfBounds function calls guardAgainstBookingInThePast internally:

function guardAgainstBookingInThePast(date: Date) {
  if (date >= new Date()) {
    // Date is in the future.
    return;
  }
  throw new BookingDateInPastError();
}

Solution:

Since any error code wasn't specified, we were throwing 500 by default. Now we throw a trpc error with BAD_REQUEST code, so 400 will be thrown instead.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Added an unit test

[coderabbitai]

Walkthrough

A new test suite was added to validate the handling of the BookingDateInPastError within the booking slot utility logic. The implementation in the AvailableSlotsService class was updated to wrap the call to isTimeOutOfBounds in a try-catch block, specifically catching the BookingDateInPastError and rethrowing it as a TRPCError with a BAD_REQUEST code. The test ensures that attempting to book a slot in the past results in the correct error conversion. No changes were made to exported or public entity declarations.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/trpc/server/routers/viewer/slots/util.test.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/trpc/server/routers/viewer/slots/util.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 16, 2025 10:18pm
cal-eu	⬜️ Ignored (Inspect)			Jul 16, 2025 10:18pm

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 0dc95a7.

Security Overview

• 🔎 Scanned files: 2 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► util.test.ts     Add test for BookingDateInPastError handling ► util.ts     Improve error handling for booking date validation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b40d448 and 0dc95a7.

📒 Files selected for processing (2)

• packages/trpc/server/routers/viewer/slots/util.test.ts (1 hunks)
• packages/trpc/server/routers/viewer/slots/util.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: alishaz-polymath
PR: calcom/cal.com#22304
File: packages/prisma/schema.prisma:1068-1071
Timestamp: 2025-07-16T05:10:22.863Z
Learning: In PR #22304 for Cal.com private link expiration features, the `maxUsageCount` field was intentionally set to default to 1 (non-nullable) as a breaking change, making all existing private links single-use after migration. This was a deliberate design decision by alishaz-polymath.

🧬 Code Graph Analysis (2)

packages/trpc/server/routers/viewer/slots/util.test.ts (2)

packages/lib/isOutOfBounds.tsx (3)

• isOutOfBounds (312-364)
• isTimeOutOfBounds (209-228)
• BookingDateInPastError (10-14)

packages/platform/libraries/index.ts (1)

• TRPCError (56-56)

packages/trpc/server/routers/viewer/slots/util.ts (2)

packages/lib/isOutOfBounds.tsx (3)

• isOutOfBounds (312-364)
• isTimeOutOfBounds (209-228)
• BookingDateInPastError (10-14)

packages/platform/libraries/index.ts (1)

• TRPCError (56-56)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: required
• GitHub Check: Security Check

🔇 Additional comments (4)

packages/trpc/server/routers/viewer/slots/util.test.ts (1)

22-36: LGTM: Error handling logic correctly mirrors the implementation.

The try-catch block properly demonstrates the expected error conversion pattern, catching BookingDateInPastError and rethrowing it as a TRPCError with BAD_REQUEST code.

packages/trpc/server/routers/viewer/slots/util.ts (3)

38-38: LGTM: Correct import added for BookingDateInPastError.

The import is properly added and will be used in the error handling logic below.

---

1317-1331: LGTM: Proper error handling implementation for past booking dates.

The try-catch block correctly wraps the isTimeOutOfBounds call and converts BookingDateInPastError to a TRPCError with BAD_REQUEST code, which aligns with the PR objective to fix the error code for past bookings. The implementation properly preserves the original error message and rethrows other errors unchanged.

---

1340-1340: Verify the isOutOfBounds variable usage in filter condition.

The isOutOfBounds variable is correctly used in the filter condition. Since it's initialized to false and only set to true if isTimeOutOfBounds returns true (without throwing), the negation !isOutOfBounds properly filters out slots that are out of bounds due to minimum booking notice.

[coderabbitai]

🛠️ Refactor suggestion

Add error code assertion to strengthen the test.

The test should also verify that the thrown TRPCError has the correct error code, not just the message.

    // This should throw a TRPCError with BAD_REQUEST code
    expect(() => testFilteringLogic()).toThrow(TRPCError);
    expect(() => testFilteringLogic()).toThrow("Attempting to book a meeting in the past.");
+    
+    // Verify the error code is BAD_REQUEST
+    try {
+      testFilteringLogic();
+    } catch (error) {
+      expect(error).toBeInstanceOf(TRPCError);
+      expect((error as TRPCError).code).toBe("BAD_REQUEST");
+    }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	expect(() => testFilteringLogic()).toThrow(TRPCError);
	expect(() => testFilteringLogic()).toThrow("Attempting to book a meeting in the past.");
	});
	// This should throw a TRPCError with BAD_REQUEST code
	expect(() => testFilteringLogic()).toThrow(TRPCError);
	expect(() => testFilteringLogic()).toThrow("Attempting to book a meeting in the past.");
	// Verify the error code is BAD_REQUEST
	try {
	testFilteringLogic();
	} catch (error) {
	expect(error).toBeInstanceOf(TRPCError);
	expect((error as TRPCError).code).toBe("BAD_REQUEST");
	}
	});

🤖 Prompt for AI Agents

In packages/trpc/server/routers/viewer/slots/util.test.ts around lines 42 to 44,
the test currently checks that a TRPCError is thrown with a specific message but
does not verify the error code. Modify the test to catch the thrown error and
add an assertion that the error's code property matches the expected error code,
ensuring the test validates both the error type, message, and code.

[github-actions]

E2E results are ready!

• Workflow #68214.1 latest results