feat: add iCalSequence to new booking data#22899
Conversation
|
@Devanshusharma2005 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Possibly related PRs
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/05/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (08/05/25)1 label was added to this PR based on Keith Williams's automation. |
| dynamicEventSlugRef: !eventType.id ? eventType.slug : null, | ||
| dynamicGroupSlugRef: !eventType.id ? (reqBody.user as string).toLowerCase() : null, | ||
| iCalUID: evt.iCalUID ?? "", | ||
| iCalSequence: evt.iCalSequence ?? 0, |
There was a problem hiding this comment.
The issue is for reschedule booking not for new booking. Also need to increment the sequence on each reschedule. So iCalSequence: (evt.iCalSequence || 0) + 1,
| dynamicEventSlugRef: !eventType.id ? eventType.slug : null, | ||
| dynamicGroupSlugRef: !eventType.id ? (reqBody.user as string).toLowerCase() : null, | ||
| iCalUID: evt.iCalUID ?? "", | ||
| iCalSequence: originalRescheduledBooking ? (evt.iCalSequence || 0) + 1 : 0, |
There was a problem hiding this comment.
We have a function called getICalSequence inside the handleNewBooking file, where we handle the iCalSequence. Can you please check why it's not working and keep this change in a single place?
There was a problem hiding this comment.
Sure. Will look at it.
|
This PR is being marked as stale due to inactivity. |
E2E results are ready! |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist