fix: contact support button overlap#22952
Conversation
|
@bandhan-majumder is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis change set includes four files with minor updates. The order of CSS utility classes in the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
ui
|
can I get a review? have added the screen shots of prev and after the addition |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/07/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (08/07/25)1 label was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
the
🧹 Improvements
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/tailwind.config.js (1)
5-9: Confirm glob path; current pattern is likely redundant & may slow the Tailwind scanner
"../../apps/web/lib/**/*.{js,ts,jsx,tsx}"resolves back to the same folder the config file already sits in (apps/web/lib).
- If
base.contentalready coversapps/web/**/*, this addition duplicates work.- Even if it is missing, the same folder can be picked up with the simpler relative pattern
./lib/**/*.{js,ts,jsx,tsx}, avoiding two unnecessary directory hops and keeping the glob OS-agnostic.Consider replacing it to reduce build IO and avoid future path-drift:
- "../../apps/web/lib/**/*.{js,ts,jsx,tsx}", + "./lib/**/*.{js,ts,jsx,tsx}",Please verify that no other preset/content entry already includes this directory to prevent double scanning.
|
Huh that's weird |
|
@Amit91848 |
There was a problem hiding this comment.
cal.com/packages/config/tailwind-preset.js
Lines 8 to 17 in cabd459
let's add it to contents itself so it is together with other paths
|
I meant it was working before and now stopped. Not your pr |
|
ok ok. Adding those in the content |
|
@volnei should I also change the content as suggested by @Amit91848 ? or keep it as it was before |
|
Moving it should resolve the issue as well. That's fine |
|
@bandhan-majumder Appreciate the update and your responsiveness, will approve once tests are green! |
E2E results are ready! |
* add: lib folder in tailwind config * move plainChat and contactForm from lib to components * Update tailwind-preset.js
* add: lib folder in tailwind config * move plainChat and contactForm from lib to components * Update tailwind-preset.js
5 participants
What does this PR do?
Fixes the overlap of the customer support button
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Prev Bug - Chat Button on the left top overlapping :
Fix Now - Chat button in the right bottom:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist