Skip to content

fix: SCIM group events - compare membership with teamId #22957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emrysal merged 1 commit into from
Aug 7, 2025
+1 −1
Merged

fix: SCIM group events - compare membership with teamId #22957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/features/ee/dsync/lib/handleGroupEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ const handleGroupEvents = async (event: DirectorySyncEvent, organizationId: numb
});

// Send emails to new members
const newMembers = users.filter((user) => !user.teams.find((team) => team.id === group.teamId));
const newMembers = users.filter((user) => !user.teams.find((team) => team.teamId === group.teamId));
Copy link
Member

@hariombalhara hariombalhara Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename team to membership.

I have been bitten by a similar bug too 😂

const newOrgMembers = users.filter(
(user) => !user.profiles.find((profile) => profile.organizationId === organizationId)
);
Expand Down
Loading