Skip to content

Comments

feat: confirm / decline booking as org admin managed user#23170

Closed
Devanshusharma2005 wants to merge 4 commits intomainfrom
feat/org-admin-confirm-decline-booking-tests
Closed

feat: confirm / decline booking as org admin managed user#23170
Devanshusharma2005 wants to merge 4 commits intomainfrom
feat/org-admin-confirm-decline-booking-tests

Conversation

@Devanshusharma2005
Copy link
Contributor

@Devanshusharma2005 Devanshusharma2005 commented Aug 18, 2025 •
edited
Loading

confirm / decline booking as org admin managed user

Summary

fixes : #23153

@devin-ai-integration @Devanshusharma2005
feat: add e2e tests for platform org admin booking confirmation/decli…
5e46f2f 
…ne permissions

- Add tests for platform org admin confirming/declining bookings within same org
- Add tests verifying platform org admin cannot confirm/decline cross-org bookings
- Follow existing test patterns and use proper authorization checks

Co-Authored-By: Devanshu Sharma <devanshusharma658@gmail.com>
@devin-ai-integration
Copy link
Contributor

devin-ai-integration bot commented Aug 18, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 18, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/org-admin-confirm-decline-booking-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Aug 18, 2025
@devin-ai-integration @Devanshusharma2005
feat: add organization admin authorization checks for booking confirm…
b1e24d9 
…ation

- Add logic to check if logged-in user is admin/owner of organization containing booking user
- Support both direct organization membership and team-to-organization relationships
- Maintain existing authorization checks while adding platform org admin permissions

Co-Authored-By: Devanshu Sharma <devanshusharma658@gmail.com>
@vercel
Copy link

vercel bot commented Aug 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Aug 19, 2025 3:23am
cal-eu Ignored Ignored Aug 19, 2025 3:23am

@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth organizations area: organizations, orgs platform Anything related to our platform plan ✨ feature New feature or request labels Aug 19, 2025
@Devanshusharma2005 Devanshusharma2005 changed the title feat: add e2e tests for platform org admin booking confirmation/decline permissions feat: confirm / decline booking as org admin managed user Aug 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

E2E results are ready!

@anikdhabal
Copy link
Contributor

anikdhabal commented Aug 19, 2025

Sorry but fixed by this:- #23164

@anikdhabal anikdhabal closed this Aug 19, 2025
@Devanshusharma2005
Copy link
Contributor Author

Devanshusharma2005 commented Aug 19, 2025

Sorry but fixed by this:- #23164

No problem. Time to read and learn this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api area: API, enterprise API, access token, OAuth community-interns The team responsible for reviewing, testing and shipping low/medium community PRs ✨ feature New feature or request organizations area: organizations, orgs platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: confirm / decline booking as org admin managed user

3 participants

@Devanshusharma2005 @anikdhabal @keithwillcode