-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: add paid, userEmail, userName, and rating filters to insights page #23299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+100
−2
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2f3f9d2
feat: add paid, userEmail, and userName filters to insights page
devin-ai-integration[bot] 58b7c61
fix: change paid filter from MULTI_SELECT to SINGLE_SELECT
devin-ai-integration[bot] 5dd6427
fix paid filter
eunjae-lee cc1e849
feat: add rating filter to insights page
devin-ai-integration[bot] 5aaaba3
feat: change rating filter to NUMBER type
devin-ai-integration[bot] 6e5f937
refactor: use makeSqlCondition utility for filter logic
devin-ai-integration[bot] dbeb5b4
Merge branch 'main' into devin/add-insights-filters-1755940191
eunjae-lee d28ef5f
add missing texts
eunjae-lee d47894c
Merge branch 'main' into devin/add-insights-filters-1755940191
Udit-takkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
i18n hookup looks good; ensure keys exist.
Importing useLocale and using t is correct. Please verify that "paid" and "free" keys exist in locale JSONs.
Also applies to: 28-28
🏁 Script executed:
Length of output: 3059
Add missing i18n keys for “free”, “user_email”, and “user_name”
The lookup for “paid” succeeded across all locale JSONs, but the keys “free”, “user_email”, and “user_name” were not found. Please add these entries to each
common.json(and any other relevant namespace) underapps/web/public/static/locales/*/. For example, inapps/web/public/static/locales/en/common.json:{ "paid": "Paid", + "free": "Free", + "user_email": "User email", + "user_name": "User name", … }– Repeat for every locale to ensure complete coverage.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eunjae-lee this is correct. user_email, user_name doesn't exist in common.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar thanks for pointing it out ! just added a commit for that