Skip to content

fix: getting error when userid passed into booking filters #23344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anikdhabal merged 2 commits into from
Aug 25, 2025
Merged

fix: getting error when userid passed into booking filters #23344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e7be5
fix get booking issue
anikdhabal Aug 25, 2025
52cd0bd
Merge branch 'main' into filter_issue
anikdhabal Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/trpc/server/routers/viewer/bookings/get.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,12 @@ export async function getBookings({
userIdsWhereUserIsAdminOrOwner.includes(userId)
);

const isCurrentUser = filters.userIds.length === 1 && user.id === filters.userIds[0];

// Scope depends on `user.orgId`:
// - Throw an error if trying to filter by usersIds that are not within your ORG
// - Throw an error if trying to filter by usersIds that are not within your TEAM
if (!areUserIdsWithinUserOrgOrTeam) {
if (!areUserIdsWithinUserOrgOrTeam && !isCurrentUser) {
throw new TRPCError({
code: "FORBIDDEN",
message: "You do not have permissions to fetch bookings for specified userIds",
Expand Down
Loading