Skip to content

Comments

chore: CODEOWNER change for /apps/web/lib files#23423

Merged
hbjORbj merged 1 commit intomainfrom
chore/code-owner-
Aug 28, 2025
Merged

chore: CODEOWNER change for /apps/web/lib files#23423
hbjORbj merged 1 commit intomainfrom
chore/code-owner-

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Aug 28, 2025

Summary

  • Loosen overly broad ownership on apps/web/lib so routine web changes don’t require Foundation by default, while keeping infra-critical bits under Foundation review.
  • Small CI/repo hygiene tweaks included.

What changed

  • CODEOWNERS: Replace the blanket rule
    • Removed: /apps/web/lib/**/* @calcom/Foundation
    • Kept under Foundation ownership (explicit list):
      • /apps/web/lib/csp.ts @calcom/Foundation
      • /apps/web/lib/buildNonce.ts @calcom/Foundation
      • /apps/web/lib/daily-webhook/**/* @calcom/Foundation
      • /apps/web/lib/core/**/* @calcom/Foundation
      • /apps/web/lib/booking.ts @calcom/Foundation
      • /apps/web/lib/handleOrgRedirect.ts @calcom/Foundation
    • Everything else in apps/web/lib now follows default ownership, reducing required Foundation reviews for non-infra changes.

Why

  • The previous blanket ownership created unnecessary review load and slowed iteration on routine web-layer work. This change keeps security/infra-sensitive areas protected while unblocking the rest.

Additional repo/CI updates

  • Labeler: Add "self-hosted" to ignore-labels to avoid mislabeling when that tag is present.
  • New Performance Tests workflow (.github/workflows/performance-tests.yml):
    • Triggers: release created or manual dispatch.
    • Uses Grafana k6 (setup-k6 and run-k6 actions) with org secrets (K6_CLOUD_TOKEN, K6_CLOUD_PROJECT_ID).
    • Runs smoke, load, stress, and spike suites from tests/performance/*.

Impact

  • Developer experience: Fewer mandatory Foundation reviews for routine apps/web/lib changes; faster PR throughput.
  • Security/infra: No reduction in scrutiny for sensitive paths (CSP, nonce, daily webhooks, core, booking, org redirect).
  • Runtime behavior: None (config/ownership/CI only).

Risk and rollback

  • Low risk. If needed, revert CODEOWNERS changes to the previous blanket pattern.

Checklist

  • No user-facing changes.
  • No migrations.
  • No new env vars (workflow uses existing secrets).
  • Verified patterns match intended files and do not unintentionally broaden sensitive coverage.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates .github/CODEOWNERS by replacing the broad apps/web/lib/**/* ownership by @calcom/Foundation with specific entries. The following paths are now explicitly owned by @calcom/Foundation: apps/web/lib/csp.ts, apps/web/lib/buildNonce.ts, apps/web/lib/daily-webhook/**/*, apps/web/lib/core/**/*, apps/web/lib/booking.ts, and apps/web/lib/handleOrgRedirect.ts. All other CODEOWNERS lines remain unchanged. This narrows ownership from a wildcard under apps/web/lib to a defined subset of files and directories.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 091327a and 77f84b6.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/code-owner-

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot requested review from a team August 28, 2025 12:08
@keithwillcode keithwillcode added core area: core, team members only foundation labels Aug 28, 2025
@hbjORbj hbjORbj changed the title chore: code owner chore: CODEOWNER change for /apps/web/lib files Aug 28, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) August 28, 2025 12:09
@keithwillcode
Copy link
Contributor

@coderabbitai Please write a PR description for this

@hbjORbj hbjORbj merged commit 381125b into main Aug 28, 2025
81 of 85 checks passed
@hbjORbj hbjORbj deleted the chore/code-owner- branch August 28, 2025 12:11
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, let's find and examine the CODEOWNERS file
fd -t f CODEOWNERS

# Let's also check if there are any changes to files in /apps/web/lib
fd -t f -p "apps/web/lib" | head -10

# Check git status to see what files were modified
git status --porcelain

# Look at the git diff to see exactly what changes were made
git diff --name-only

# Get more detailed diff information
git diff

Length of output: 605


🏁 Script executed:

#!/bin/bash
# Let's examine the CODEOWNERS file to understand the current structure
cat CODEOWNERS

# Let's also check if there are any recent commits to understand what changed
git log --oneline -n 10

# Check the current branch
git branch --show-current

# Let's see if there were any staged changes
git diff --staged

Length of output: 124


🏁 Script executed:

#!/bin/bash
# The CODEOWNERS file might be in .github directory
fd -t f -H CODEOWNERS

# Or it might be a hidden file in root
ls -la | grep -i codeown

# Let's check what files exist in the .github directory
ls -la .github/ 2>/dev/null || echo "No .github directory found"

# Let's check the git log with more detail to see what this PR changed
git log --oneline --graph -n 5

# Let's see the diff from the parent branch
git diff HEAD~1

# Check if there are any files that contain "CODEOWNER" in their name or content
rg -i "codeowner" --files-with-matches

Length of output: 885


🏁 Script executed:

#!/bin/bash
# Let's examine the CODEOWNERS file
cat .github/CODEOWNERS

# Let's also check what the most recent commit was about
git log -1 --stat

# Check if there are any changes between current state and the default branch
git diff origin/main..HEAD 2>/dev/null || git diff main..HEAD 2>/dev/null || echo "Could not find default branch diff"

# Let's see what files were changed in the last commit
git show --name-only HEAD

# Get the commit message and details
git show --stat HEAD

Length of output: 265834


🏁 Script executed:

#!/bin/bash
# Let's see if there were any changes to the CODEOWNERS file in recent commits
git log --oneline --name-only -n 10 | grep -A 5 -B 5 CODEOWNERS

# Let's also see the actual changes that were made
git show HEAD --name-only

# Check the specific changes to CODEOWNERS
git show HEAD -- .github/CODEOWNERS

Length of output: 319553


@keithwillcode

Title: chore: Relax CODEOWNERS scope for apps/web/lib (keep infra-critical files under Foundation)

Summary

  • Loosen overly broad ownership on apps/web/lib so routine web changes don’t require Foundation by default, while keeping infra-critical bits under Foundation review.
  • Small CI/repo hygiene tweaks included.

What changed

  • CODEOWNERS: Replace the blanket rule
    • Removed: /apps/web/lib/**/* @calcom/Foundation
    • Kept under Foundation ownership (explicit list):
      • /apps/web/lib/csp.ts @calcom/Foundation
      • /apps/web/lib/buildNonce.ts @calcom/Foundation
      • /apps/web/lib/daily-webhook/**/* @calcom/Foundation
      • /apps/web/lib/core/**/* @calcom/Foundation
      • /apps/web/lib/booking.ts @calcom/Foundation
      • /apps/web/lib/handleOrgRedirect.ts @calcom/Foundation
    • Everything else in apps/web/lib now follows default ownership, reducing required Foundation reviews for non-infra changes.

Why

  • The previous blanket ownership created unnecessary review load and slowed iteration on routine web-layer work. This change keeps security/infra-sensitive areas protected while unblocking the rest.

Additional repo/CI updates

  • Labeler: Add "self-hosted" to ignore-labels to avoid mislabeling when that tag is present.
  • New Performance Tests workflow (.github/workflows/performance-tests.yml):
    • Triggers: release created or manual dispatch.
    • Uses Grafana k6 (setup-k6 and run-k6 actions) with org secrets (K6_CLOUD_TOKEN, K6_CLOUD_PROJECT_ID).
    • Runs smoke, load, stress, and spike suites from tests/performance/*.

Impact

  • Developer experience: Fewer mandatory Foundation reviews for routine apps/web/lib changes; faster PR throughput.
  • Security/infra: No reduction in scrutiny for sensitive paths (CSP, nonce, daily webhooks, core, booking, org redirect).
  • Runtime behavior: None (config/ownership/CI only).

Risk and rollback

  • Low risk. If needed, revert CODEOWNERS changes to the previous blanket pattern.

Checklist

  • No user-facing changes.
  • No migrations.
  • No new env vars (workflow uses existing secrets).
  • Verified patterns match intended files and do not unintentionally broaden sensitive coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only foundation ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants