Skip to content

fix: remove duplicate values found in common.keys #23477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeneCodeSavvy wants to merge 4 commits into from
Closed

fix: remove duplicate values found in common.keys #23477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63e091a
fix
GeneCodeSavvy Aug 31, 2025
51f1d42
some fix
anikdhabal Aug 31, 2025
f8a522a
replaced some instances of removed keys
GeneCodeSavvy Aug 31, 2025
cdc5c99
Merge branch 'main' into rm-duplicates
Devanshusharma2005 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/components/apps/AppPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ export const AppPage = ({
{teamsPlanRequired ? (
t("teams_plan_required")
) : price === 0 ? (
t("free_to_use_apps")
t("free")
) : (
<>
{Intl.NumberFormat(i18n.language, {
Expand Down
32 changes: 2 additions & 30 deletions apps/web/public/static/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,6 @@
"event_type_updated_successfully": "{{eventTypeTitle}} event type updated successfully",
"event_type_deleted_successfully": "Event type deleted successfully",
"hours": "Hours",
"people": "People",
"your_email": "Your Email",
"change_avatar": "Change Avatar",
"upload_avatar": "Upload Avatar",
Expand Down Expand Up @@ -1164,7 +1163,6 @@
"trending_apps": "Trending Apps",
"most_popular": "Most Popular",
"installed_apps": "Installed Apps",
"free_to_use_apps": "Free",
"no_category_apps": "No {{category}} apps",
"all_apps": "All apps",
"no_category_apps_description_calendar": "Add a calendar app to check for conflicts to prevent double bookings",
Expand Down Expand Up @@ -1578,7 +1576,6 @@
"event_limit_tab_title": "Limits",
"event_limit_tab_description": "How often you can be booked",
"event_advanced_tab_description": "Calendar settings & more...",
"event_advanced_tab_title": "Advanced",
"event_payments_tab_description": "Set up payments for event",
"event_setup_multiple_duration_error": "Event Setup: Multiple durations requires at least 1 option.",
"event_setup_multiple_duration_default_error": "Event Setup: Please select a valid default duration.",
Expand Down Expand Up @@ -1679,14 +1676,12 @@
"message_template": "Message template",
"email_subject": "Email subject",
"add_dynamic_variables": "Add dynamic text variables",
"event_name_info": "The event type name",
"event_date_info": "The event date",
"event_duration_info": "The event duration",
"event_time_info": "The event start time",
"event_name_info": "The event type name",
"event_type_not_found": "EventType not Found",
"location_variable": "Location",
"location_info": "The location of the event",
"additional_notes_variable": "Additional notes",
"additional_notes_info": "The additional notes of booking",
"attendee_name_info": "The person booking's name",
"organizer_name_info": "Organizer's name",
Expand Down Expand Up @@ -2199,7 +2194,6 @@
"can_you_try_again": "Can you try again with a different time?",
"verify": "Verify",
"timezone_info": "The timezone of the person receiving",
"timezone_variable": "Timezone",
"event_end_time_variable": "Event end time",
"event_end_time_info": "The event end time",
"cancel_url_variable": "Cancel URL",
Expand Down Expand Up @@ -2609,7 +2603,6 @@
"extensive_whitelabeling": "Extensive Whitelabeling",
"extensive_whitelabeling_description": "Customize your scheduling experience with your own logo, colors, and more",
"unlimited_teams": "Unlimited Teams",
"verify_email": "Verify email",
"proceed_with_cancellation_description": "Please enter the email address used for this booking to proceed with cancellation",
"proceed_with_cancellation_error": "Email doesn't match the booking email",
"unlimited_teams_description": "Add as many subteams as you need to your organization",
Expand Down Expand Up @@ -3015,10 +3008,6 @@
"row": "row",
"rows": "rows",
"attendee_timezone_variable": "Attendee Timezone",
"event_start_time_in_attendee_timezone_variable": "Event Start Time In Attendee Timezone",
"event_start_time_in_attendee_timezone_info": "Event Start Time In Attendee Timezone",
"event_end_time_in_attendee_timezone_info": "Event End Time In Attendee Timezone",
"event_end_time_in_attendee_timezone_variable": "Event End Time In Attendee Timezone",
"salesforce_create_event_on_contact": "Create event on contact, if it exists. Else fallback to lead",
"salesforce_owner_name_to_change": "Owner name to change",
"no_filter_set": "No filter set",
Expand Down Expand Up @@ -3381,37 +3370,25 @@
"none": "None",
"read_only": "Read only",
"pbac_desc_all_actions_all_resources": "All actions on all resources",
"pbac_resource_all": "All Resources",
"pbac_resource_event_type": "Event Types",
"pbac_resource_team": "Teams",
"pbac_resource_organization": "Organization",
"pbac_resource_booking": "Bookings",
"pbac_resource_insights": "Insights",
Comment on lines -3384 to -3389
Copy link
Contributor

@anikdhabal anikdhabal Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These keys were removed due to duplication, but I think they are still not fully removed, or their alternatives are not being used in the code. Please verify all the removed keys. cc @kart1ka for quick review

Copy link
Contributor

@anikdhabal anikdhabal Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pbac_resource_all" is currently being used, so keep it

"pbac_resource_role": "Roles",
"pbac_resource_workflow": "Workflows",
"pbac_action_all": "All Actions",
"pbac_action_create": "Create",
"pbac_action_read": "View",
"pbac_action_update": "Edit",
"pbac_action_delete": "Delete",
"pbac_action_manage": "Manage",
"pbac_action_invite": "Invite",
"pbac_action_remove": "Remove",
"pbac_action_change_member_role": "Change Member Role",
"pbac_action_list_members": "List Members",
"pbac_action_manage_billing": "Manage Billing",
"pbac_action_read_team_bookings": "View Team Bookings",
"pbac_action_read_org_bookings": "View Organization Bookings",
"pbac_action_read_recordings": "View Recordings",
"role_created_successfully": "Role created successfully",
"pbac_resource_all": "All Resources",
"role_updated_successfully": "Role updated successfully",
"delete_role": "Delete role",
"confirm_delete_role": "Are you sure you want to delete this role? This action cannot be undone.",
"role_deleted_successfully": "Role deleted successfully",
"error_creating_role": "Error creating role",
"error_updating_role": "Error updating role",
"pbac_desc_create_roles": "Create roles",
"pbac_resource_attributes": "Attributes",
"pbac_desc_view_organization_attributes": "View organization attributes",
"pbac_desc_update_organization_attributes": "Update organization attributes",
"pbac_desc_delete_organization_attributes": "Delete organization attributes",
Expand Down Expand Up @@ -3441,7 +3418,6 @@
"pbac_desc_create_organization": "Create organization",
"pbac_desc_view_organization_details": "View organization details",
"pbac_desc_list_organization_members": "List organization members",
"pbac_desc_invite_organization_members": "Invite organization members",
"pbac_desc_remove_organization_members": "Remove organization members",
"pbac_desc_manage_organization_billing": "Manage organization billing",
"pbac_desc_change_organization_member_role": "Change role of organization members",
Expand Down Expand Up @@ -3491,7 +3467,6 @@
"enter_license_key": "Enter License Key",
"enter_your_license_key": "Access to all enterprise features",
"enter_existing_license": "Starting at $15/user per month",
"enter_license_key_description": "Access to all enterprise features",
"license_key_placeholder": "Enter your license key",
"save_license_key": "Save License Key",
"signature_token_optional": "Signature token (optional)",
Expand Down Expand Up @@ -3545,14 +3520,12 @@
"webhook_trigger_event": "The name of the trigger event (e.g., BOOKING_CREATED, BOOKING_CANCELLED)",
"webhook_created_at": "The time of the webhook",
"webhook_type": "The event type slug",
"webhook_title": "The event type name",
"webhook_start_time": "The event's start time",
"webhook_end_time": "The event's end time",
"webhook_description": "The event's description as described in the event type settings",
"webhook_location": "Location of the event",
"webhook_uid": "The UID of the booking",
"webhook_reschedule_uid": "The UID for rescheduling",
"webhook_cancellation_reason": "Reason for cancellation",
"webhook_rejection_reason": "Reason for rejection",
"webhook_organizer_name": "Name of the organizer",
"webhook_organizer_email": "Email of the organizer",
Expand All @@ -3569,7 +3542,6 @@
"webhook_show_variable": "Show available variables",
"webhook_event_and_booking": "Event and Booking",
"webhook_people": "People",
"webhook_teams": "Teams",
"webhook_metadata": "Metadata",
"stats": "Stats",
"booking_status": "Booking status",
Expand Down
Loading
Loading