-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: booking-delete-service-with-audit-log #23501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dce3233
feature: booking-delete-service-with-audit-log
hemantmm 4f578ab
Merge branch 'main' into booking-delete-service
hemantmm 1ada788
coderabbit suggestion
hemantmm c8536b7
Merge branch 'booking-delete-service' of https://github.com/hemantmm/…
hemantmm 0455352
Merge branch 'main' into booking-delete-service
hemantmm 912a5f0
typechecks
hemantmm 289521a
Merge branch 'booking-delete-service' of https://github.com/hemantmm/…
hemantmm fec3bff
fix: typechecks and unit-test
hemantmm 8d662df
Merge branch 'main' into booking-delete-service
kart1ka d0d22d1
Merge branch 'main' into booking-delete-service
hemantmm 4d27299
Merge branch 'main' into booking-delete-service
hemantmm bd1d6f7
Merge branch 'main' into booking-delete-service
hemantmm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import prisma from "@calcom/prisma"; | ||
| import { BookingStatus } from "@calcom/prisma/enums"; | ||
|
|
||
| type AuditLogContext = { | ||
| type: string; | ||
| wasRescheduled?: boolean; | ||
| totalUpdates?: number; | ||
| actor: { type: string; id?: number; email?: string }; | ||
| [key: string]: any; | ||
| }; | ||
|
|
||
| export class BookingDeleteService { | ||
| static async deleteBooking({ | ||
| bookingId, | ||
| actor, | ||
| wasRescheduled = false, | ||
| totalUpdates = 0, | ||
| additionalContext = {}, | ||
| }: { | ||
| bookingId: number; | ||
| actor: { type: string; id?: number; email?: string }; | ||
| wasRescheduled?: boolean; | ||
| totalUpdates?: number; | ||
| additionalContext?: Record<string, any>; | ||
| }) { | ||
| // Delete the booking (soft delete or update status as needed) | ||
| const booking = await prisma.booking.update({ | ||
| where: { id: bookingId }, | ||
| data: { status: BookingStatus.CANCELLED }, | ||
| select: { id: true }, | ||
| }); | ||
|
|
||
| // Create audit log entry | ||
| const context: AuditLogContext = { | ||
| ...additionalContext, | ||
| type: "record_deleted", | ||
| wasRescheduled, | ||
| totalUpdates, | ||
| actor, | ||
| }; | ||
|
|
||
| await prisma.$transaction(async (tx) => { | ||
| // Only attempt auditlog if it exists (skip in test envs like Prismock) | ||
| if ((tx as any).auditlog && typeof (tx as any).auditlog.create === "function") { | ||
| await (tx as any).auditlog.create({ | ||
| data: { entity: "booking", entityId: bookingId, action: "delete", context }, | ||
| }); | ||
| } | ||
| // else: skip audit log in test/mock environments | ||
| }); | ||
|
|
||
| return booking; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use
anyhere. There is no such model asauditlogin the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as mentioned in the issue we should ensure that an
auditlogentry is created for the deletion