Skip to content

Comments

fix: update E2E Atoms workflow naming to match convention#23512

Merged
keithwillcode merged 2 commits intomainfrom
devin/e2e-atoms-naming-1756816462
Sep 2, 2025
Merged

fix: update E2E Atoms workflow naming to match convention#23512
keithwillcode merged 2 commits intomainfrom
devin/e2e-atoms-naming-1756816462

Conversation

@keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Sep 2, 2025

What does this PR do?

Updates the GitHub Actions workflow name from "Atoms E2E Tests" to "E2E Atoms" to match the naming convention used by other E2E test workflows in the repository.

Changes made:

  • Workflow name: Atoms E2E Tests → E2E Atoms
  • Job name: Atoms E2E Tests → E2E Atoms
  • Step name: Run Atoms E2E Tests → Run E2E Atoms Tests

Motivation:
Other E2E workflows follow the "E2E [Component]" pattern:

  • E2E (main E2E tests)
  • E2E App Store Tests
  • E2E Embed Core tests and booking flow (for non-embed as well)

The Atoms workflow was the only one using "Atoms E2E Tests" instead of "E2E Atoms".

How should this be tested?

  • Verify YAML syntax is valid
  • Confirm the workflow name appears correctly in GitHub Actions UI
  • Check that no external references to "Atoms E2E Tests" exist in the codebase or documentation
  • Validate that the workflow still triggers and runs as expected

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Link to Devin run: https://app.devin.ai/sessions/9db22d5ce90a4153b13b4216fea0ef0a
Requested by: @keithwillcode

@devin-ai-integration @keithwillcode
fix: update E2E Atoms workflow naming to match convention
90ed108 
- Change workflow name from 'Atoms E2E Tests' to 'E2E Atoms'
- Update job name to match new convention
- Update step name for consistency
- Aligns with naming pattern used by other E2E workflows

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
@devin-ai-integration
Copy link
Contributor

devin-ai-integration bot commented Sep 2, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 2, 2025 •
edited
Loading

Walkthrough

  • Updated .github/workflows/e2e-atoms.yml.
  • Renamed workflow from "Atoms E2E Tests" to "E2E Atoms".
  • Renamed the job label from "Atoms E2E Tests" to "E2E Atoms".
  • Renamed the step label from "Run Atoms E2E Tests" to "Run E2E Atoms Tests".
  • No changes to workflow logic, order, or commands.

Possibly related PRs

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6b84dc0 and 90ed108.

📒 Files selected for processing (1)
  • .github/workflows/e2e-atoms.yml (3 hunks)
🔇 Additional comments (3)
.github/workflows/e2e-atoms.yml (3)

33-33: Rename safe; no log parsers affected
Scanned entire repo for the old step label “Run Atoms E2E Tests” and found no references—no further changes required.

1-1: Workflow name rename approved: no lingering references found. Safe to merge.

22-22: Verify branch protection required status checks
Confirm that branch protection rules have been updated to use “E2E Atoms” instead of the old “Atoms E2E Tests” check name; update via GitHub UI or API if not.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/e2e-atoms-naming-1756816462

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keithwillcode keithwillcode added core area: core, team members only foundation labels Sep 2, 2025
@keithwillcode keithwillcode marked this pull request as ready for review September 2, 2025 13:01
@graphite-app graphite-app bot requested a review from a team September 2, 2025 13:01
@dosubot dosubot bot added the ci area: CI, DX, pipeline, github actions label Sep 2, 2025
@keithwillcode keithwillcode enabled auto-merge (squash) September 2, 2025 13:07
@vercel
Copy link

vercel bot commented Sep 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Sep 2, 2025 1:20pm
cal-eu Ignored Ignored Sep 2, 2025 1:20pm

@keithwillcode keithwillcode merged commit a1fab0e into main Sep 2, 2025
36 of 37 checks passed
@keithwillcode keithwillcode deleted the devin/e2e-atoms-naming-1756816462 branch September 2, 2025 13:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

E2E results are ready!

VeerNandanDas added a commit to VeerNandanDas/cal.com that referenced this pull request Sep 2, 2025
@VeerNandanDas
fix: update E2E Atoms workflow naming to match convention (calcom#23512)
f0984a3 
- Change workflow name from 'Atoms E2E Tests' to 'E2E Atoms'
- Update job name to match new convention
- Update step name for consistency
- Aligns with naming pattern used by other E2E workflows

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

## What does this PR do?

<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->

- Fixes #XXXX (GitHub issue number)
- Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

## Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change **(video / image - any one)**.

#### Video Demo (if applicable):

- Show screen recordings of the issue or feature.
- Demonstrate how to reproduce the issue, the behavior before and after the change.

#### Image Demo (if applicable):

- Add side-by-side screenshots of the original and updated change.
- Highlight any significant change(s).

## Mandatory Tasks (DO NOT REMOVE)

- [ ] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [ ] I have updated the developer docs in /docs if this PR makes changes that would require a [documentation change](https://cal.com/docs). If N/A, write N/A here and check the checkbox.
- [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

## How should this be tested?

<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Write details that help to start the tests -->

- Are there environment variables that should be set?
- What are the minimal test data to have?
- What is expected (happy path) to have (input and output)?
- Any other important info that could help to test that PR

## Checklist

<!-- Remove bullet points below that don't apply to you -->

- I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md)
- My code doesn't follow the style guidelines of this project
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@volnei volnei volnei approved these changes

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees

No one assigned

Labels

ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keithwillcode @volnei @anikdhabal