Skip to content

perf: Remove next-i18next dependency from packages/emails and packages/lib #23531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volnei merged 4 commits into from
Sep 3, 2025
Merged

perf: Remove next-i18next dependency from packages/emails and packages/lib #23531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24f4b44
refactor: Remove type imports from next-i18next package
hbjORbj Sep 3, 2025
9247b45
remove next-i18next from packages/lib
hbjORbj Sep 3, 2025
5efa3a7
remove next-i18next from packages/emails
hbjORbj Sep 3, 2025
a14e7e7
Merge branch 'main' into refactor/remove-type-imports-from-next-i18next
hbjORbj Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/emails/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"dependencies": {
"@calcom/dayjs": "*",
"@calcom/lib": "*",
"next-i18next": "^15.4.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"rrule": "^2.7.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/emails/src/templates/CreditBalanceLimitReachedEmail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { TFunction } from "next-i18next";
import type { TFunction } from "i18next";

import { WEBAPP_URL } from "@calcom/lib/constants";

Expand Down
2 changes: 1 addition & 1 deletion packages/emails/src/templates/CreditBalanceLowWarningEmail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { TFunction } from "next-i18next";
import type { TFunction } from "i18next";

import { WEBAPP_URL } from "@calcom/lib/constants";

Expand Down
2 changes: 1 addition & 1 deletion packages/features/CalendarEventBuilder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { TFunction } from "next-i18next";
import type { TFunction } from "i18next";
import { describe, expect, it, vi } from "vitest";

import dayjs from "@calcom/dayjs";
Expand Down
2 changes: 1 addition & 1 deletion packages/features/CalendarEventBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Prisma } from "@prisma/client";
import type { TFunction } from "next-i18next";
import type { TFunction } from "i18next";
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Type import source switch looks correct and side-effect free

Using import type { TFunction } from "i18next" matches the refactor goal and won’t affect runtime.

Run this to ensure there are no lingering next-i18next type imports or deps across the repo:

🏁 Script executed:

#!/bin/bash
# Find any remaining next-i18next imports
rg -nP --type=ts --type=tsx $'from\\s+[\"\']next-i18next[\"\']'

# Specifically catch TFunction from next-i18next
rg -nP --type=ts --type=tsx $'import\\s+type\\s*\\{[^}]*\\bTFunction\\b[^}]*\\}\\s*from\\s*[\"\']next-i18next[\"\']'

# Check package.json files for next-i18next and verify i18next presence
rg -n '\"next-i18next\"' -g '**/package.json'
echo '--- i18next occurrences ---'
rg -n '\"i18next\"' -g '**/package.json'

Length of output: 550

🏁 Script executed:

#!/bin/bash
# Search for any remaining next-i18next imports in .ts and .tsx files
rg -nP 'from\s+["\x27]next-i18next["\x27]' -g '*.ts' -g '*.tsx'

# Specifically catch TFunction imported from next-i18next
rg -nP 'import\s+type\s*\{[^}]*\bTFunction\b[^}]*\}\s*from\s+["\x27]next-i18next["\x27]' -g '*.ts' -g '*.tsx'

# Check package.json files for next-i18next dependency
rg -n '"next-i18next"' -g '**/package.json'

echo '--- i18next occurrences ---'
# Verify presence of i18next in package.json files
rg -n '"i18next"' -g '**/package.json'

Length of output: 525

Remove or update remaining next-i18next usages

  • Runtime import in apps/web/lib/app-providers.tsx:6:
    import { appWithTranslation } from "next-i18next"
  • Dependency in apps/web/package.json:112:
    "next-i18next": "^15.4.2"
🤖 Prompt for AI Agents 
packages/features/CalendarEventBuilder.ts around line 2: leftover i18n wiring
references to next-i18next remain; remove or update all next-i18next usages
across the repo by (1) removing the runtime import appWithTranslation from
apps/web/lib/app-providers.tsx and replacing it with the project’s chosen i18n
integration (or the framework’s native i18n wrapper) so no runtime import to
next-i18next is required, (2) removing the next-i18next dependency from
apps/web/package.json (or replacing it with the correct i18n package and
updating import sites), and (3) in this file ensure only correct types/imports
are used (keep type imports from i18next if the project uses i18next, otherwise
remove or replace them to match the chosen i18n library).


import type { TimeFormat } from "@calcom/lib/timeFormat";
import type { SchedulingType } from "@calcom/prisma/enums";
Expand Down
1 change: 0 additions & 1 deletion packages/lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"jimp": "^0.16.1",
"lingo.dev": "^0.111.1",
"next-collect": "^0.2.1",
"next-i18next": "^15.4.2",
"rrule": "^2.7.1",
"sharp": "0.33.5",
"sonner": "^1.7.4",
Expand Down
Loading