Skip to content

Comments

chore: Add .mdx to all checks ignore list#23627

Merged
keithwillcode merged 2 commits intomainfrom
chore/ignore-mdx-all-checks
Sep 5, 2025
Merged

chore: Add .mdx to all checks ignore list#23627
keithwillcode merged 2 commits intomainfrom
chore/ignore-mdx-all-checks

Conversation

@keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Sep 5, 2025

We don't need to run all checks for .mdx files.

@keithwillcode keithwillcode self-assigned this Sep 5, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 5, 2025

Walkthrough

The PR updates .github/workflows/pr.yml by extending the has-files-requiring-all-checks exclusion patterns to include **.mdx, so MDX file changes are excluded from triggering the all-checks behavior. No other exclusions are modified. No exported or public entities are changed.

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/ignore-mdx-all-checks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot requested a review from a team September 5, 2025 16:02
@keithwillcode keithwillcode added core area: core, team members only foundation labels Sep 5, 2025
joeauyeung
joeauyeung previously approved these changes Sep 5, 2025
anikdhabal
anikdhabal previously approved these changes Sep 5, 2025
volnei
volnei previously approved these changes Sep 5, 2025
@dosubot dosubot bot added the ci area: CI, DX, pipeline, github actions label Sep 5, 2025
@keithwillcode keithwillcode dismissed stale reviews from volnei, anikdhabal, and joeauyeung via 262d12d September 5, 2025 16:05
@vercel
Copy link

vercel bot commented Sep 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Sep 5, 2025 4:05pm
cal-eu Ignored Ignored Sep 5, 2025 4:05pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/pr.yml (1)

36-36: Nit: prefer explicit “/.mdx” (and “**/.md”) for clarity; consider uppercase variants.**

While **.mdx works with minimatch extglobs here, **/*.mdx is more conventional. If your repo may contain uppercase extensions, add **/*.MDX too.

-              - "!(**.md|**.mdx|.github/CODEOWNERS|docs/**|help/**|apps/web/public/static/locales/**/common.json|i18n.lock)"
+              - "!(**/*.md|**/*.MD|**/*.mdx|**/*.MDX|.github/CODEOWNERS|docs/**|help/**|apps/web/public/static/locales/**/common.json|i18n.lock)"
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9fea30a and 262d12d.

📒 Files selected for processing (1)
  • .github/workflows/pr.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Production builds / Build API v2
  • GitHub Check: Production builds / Build Atoms
  • GitHub Check: Production builds / Build API v1
  • GitHub Check: Production builds / Build Docs
  • GitHub Check: Tests / Unit
  • GitHub Check: Production builds / Build Web App
  • GitHub Check: Type check / check-types
  • GitHub Check: Linters / lint
🔇 Additional comments (1)
.github/workflows/pr.yml (1)

36-36: MDX correctly added to ignore list for “all-checks”.

This matches the existing extglob style and fulfills the PR goal: MDX-only changes won’t trigger the full suite.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

E2E results are ready!

@keithwillcode keithwillcode merged commit 71a2b69 into main Sep 5, 2025
66 of 68 checks passed
@keithwillcode keithwillcode deleted the chore/ignore-mdx-all-checks branch September 5, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants