-
Notifications
You must be signed in to change notification settings - Fork 12k
refactor: circular deps between app store and lib [1] #23653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
89211b1
b96ef76
7cf6581
94d4f4a
6a72c83
d5b72bb
ad224f8
7e3e9c6
e4f5a70
cd82521
9b27707
3ea3ef8
a53e3da
5072e05
e3bb190
a08e5bc
d7435ed
5d318b8
2255e14
f44e827
1a430f1
0716d8b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -26,12 +26,12 @@ import { | |||||||
| SystemField, | ||||||||
| TITLE_FIELD, | ||||||||
| } from "@calcom/features/bookings/lib/SystemField"; | ||||||||
| import { getCalendarLinks, CalendarLinkType } from "@calcom/features/bookings/lib/getCalendarLinks"; | ||||||||
| import { RATING_OPTIONS, validateRating } from "@calcom/features/bookings/lib/rating"; | ||||||||
| import { getCalendarLinks, CalendarLinkType } from "@calcom/lib/bookings/getCalendarLinks"; | ||||||||
| import type { nameObjectSchema } from "@calcom/features/eventtypes/lib/eventNaming"; | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Type-only import breaks
Apply this diff: -import type { nameObjectSchema } from "@calcom/features/eventtypes/lib/eventNaming";
+import { nameObjectSchema } from "@calcom/features/eventtypes/lib/eventNaming";If the module exports a dedicated type (e.g., -import type { nameObjectSchema } from "@calcom/features/eventtypes/lib/eventNaming";
+import type { NameObject } from "@calcom/features/eventtypes/lib/eventNaming";and update usage: - attendeeName: bookingInfo.responses.name as z.infer<typeof nameObjectSchema> | string,
+ attendeeName: bookingInfo.responses.name as NameObject | string,📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||
| import { getEventName } from "@calcom/features/eventtypes/lib/eventNaming"; | ||||||||
| import { APP_NAME } from "@calcom/lib/constants"; | ||||||||
| import { formatToLocalizedDate, formatToLocalizedTime, formatToLocalizedTimezone } from "@calcom/lib/dayjs"; | ||||||||
| import type { nameObjectSchema } from "@calcom/lib/event"; | ||||||||
| import { getEventName } from "@calcom/lib/event"; | ||||||||
| import useGetBrandingColours from "@calcom/lib/getBrandColours"; | ||||||||
| import { useCompatSearchParams } from "@calcom/lib/hooks/useCompatSearchParams"; | ||||||||
| import { useLocale } from "@calcom/lib/hooks/useLocale"; | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import { getDailyAppKeys } from "@calcom/app-store/dailyvideo/lib/getDailyAppKeys"; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Violation: |
||
| import { handleErrorsJson } from "@calcom/lib/errors"; | ||
|
|
||
| import { getDailyAppKeys } from "./getDailyAppKeys"; | ||
|
|
||
| export const fetcher = async (endpoint: string, init?: RequestInit | undefined) => { | ||
| const { api_key } = await getDailyAppKeys(); | ||
| return fetch(`https://api.daily.co/v1${endpoint}`, { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,21 +13,21 @@ import { getEventTypesFromDB } from "@calcom/features/bookings/lib/handleNewBook | |
| import AssignmentReasonRecorder, { | ||
| RRReassignmentType, | ||
| } from "@calcom/features/ee/round-robin/assignmentReason/AssignmentReasonRecorder"; | ||
| import { BookingLocationService } from "@calcom/features/ee/round-robin/lib/bookingLocationService"; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| import { | ||
| scheduleEmailReminder, | ||
| deleteScheduledEmailReminder, | ||
| } from "@calcom/features/ee/workflows/lib/reminders/emailReminderManager"; | ||
| import { scheduleWorkflowReminders } from "@calcom/features/ee/workflows/lib/reminders/reminderScheduler"; | ||
| import { getEventName } from "@calcom/features/eventtypes/lib/eventNaming"; | ||
| import { getVideoCallUrlFromCalEvent } from "@calcom/lib/CalEventParser"; | ||
| import { SENDER_NAME } from "@calcom/lib/constants"; | ||
| import { enrichUserWithDelegationCredentialsIncludeServiceAccountKey } from "@calcom/lib/delegationCredential/server"; | ||
| import { getEventName } from "@calcom/lib/event"; | ||
| import { getBookerBaseUrl } from "@calcom/lib/getBookerUrl/server"; | ||
| import { IdempotencyKeyService } from "@calcom/lib/idempotencyKey/idempotencyKeyService"; | ||
| import { isPrismaObjOrUndefined } from "@calcom/lib/isPrismaObj"; | ||
| import logger from "@calcom/lib/logger"; | ||
| import { getTranslation } from "@calcom/lib/server/i18n"; | ||
| import { BookingLocationService } from "@calcom/lib/server/service/bookingLocationService"; | ||
| import { getTimeFormatStringFromUserTimeFormat } from "@calcom/lib/timeFormat"; | ||
| import { prisma } from "@calcom/prisma"; | ||
| import { WorkflowActions, WorkflowMethods, WorkflowTriggerEvents } from "@calcom/prisma/enums"; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Path migration looks right; verify no stale imports remain
Ensure all imports now point to
@calcom/features/bookings/lib/getCalendarLinksand that enum values didn’t change.🏁 Script executed:
Length of output: 5983
Replace all remaining
@calcom/lib/event-typesimports with the new feature pathsrgoutput shows numerous residual imports referencing@calcom/lib/event-types/*; update them to their counterparts under@calcom/features/eventtypes/libbefore merging.🤖 Prompt for AI Agents