chore: use local platform libraries instead of npm package#23834
chore: use local platform libraries instead of npm package#23834ThyMinimalDev merged 9 commits intomainfrom
Conversation
Walkthrough
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
apps/api/v2/package.json (1)
41-41: Force local workspace resolution; avoid plain "*" for safetyUse the workspace protocol to guarantee linking to the local package and prevent accidental registry resolution in edge environments.
Apply this diff:
- "@calcom/platform-libraries": "*", + "@calcom/platform-libraries": "workspace:*",.github/workflows/unit-tests.yml (1)
24-24: Confirm 'local' script and mitigate heavy CI workFound @calcom/platform-libraries "local" script:
node scripts/local.js && rm -rf dist && yarn build:dev && cd ../../.. && yarn— it runs a dev build and re-runs yarn (costly in CI); replace with a lightweight CI prep, add caching for node_modules/build artifacts, or move these steps to a separate job. Invoked from .github/workflows/unit-tests.yml (yarn workspace @calcom/platform-libraries local).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
.github/workflows/e2e-api-v2.yml(1 hunks).github/workflows/unit-tests.yml(1 hunks)apps/api/v2/Dockerfile(1 hunks)apps/api/v2/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T12:29:32.592Z
Learnt from: CR
PR: calcom/cal.com#0
File: AGENTS.md:0-0
Timestamp: 2025-09-02T12:29:32.592Z
Learning: Run integration tests with `yarn test <filename> -- --integrationTestsOnly`
Applied to files:
.github/workflows/unit-tests.yml
📚 Learning: 2025-09-02T12:29:32.592Z
Learnt from: CR
PR: calcom/cal.com#0
File: AGENTS.md:0-0
Timestamp: 2025-09-02T12:29:32.592Z
Learning: Run specific end-to-end tests with `yarn e2e <filename> --grep "<testName>"`
Applied to files:
.github/workflows/e2e-api-v2.yml
🔇 Additional comments (1)
.github/workflows/e2e-api-v2.yml (1)
74-75: Standardize prep: keep "build" unless E2E needs local-linkingFound scripts for @calcom/platform-libraries: local = "node scripts/local.js && rm -rf dist && yarn build:dev && cd ../../.. && yarn"; build = "yarn vite build". Keep the current "build" step if E2E only needs a Vite production build; switch to "local" only if E2E requires the local/linking flow.
File: .github/workflows/e2e-api-v2.yml (lines 74-75)
If switching to local, apply this diff:
- yarn workspace @calcom/platform-libraries build + yarn workspace @calcom/platform-libraries local
E2E results are ready! |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist