fix: resolve 404 error when rescheduling seated event bookings due type mismatch

[anikdhabal]

What does this PR do?

Updated packages/features/form-builder/FormBuilder.tsx: in handleSubmit, added a guard for fields named "guests" requiring type "multiemail"; on mismatch, calls showToast with "guests_field_must_be_multiemail" and returns early before duplicate-field checks.

Updated tests in packages/features/form-builder/FormBuilder.test.tsx: imported screen and waitFor; mocked @calcom/ui/components/toast.showToast; added tests verifying rejection for non-multiemail guests field and acceptance for multiemail. No public API signatures changed.

[coderabbitai]

Walkthrough

• Added English locale key: guests_field_must_be_multiemail with value "Guests field must be of type 'Multiple emails'" in apps/web/public/static/locales/en/common.json.
• Updated packages/features/form-builder/FormBuilder.tsx: in handleSubmit, added a guard for fields named "guests" requiring type "multiemail"; on mismatch, calls showToast with "guests_field_must_be_multiemail" and returns early before duplicate-field checks.
• Updated tests in packages/features/form-builder/FormBuilder.test.tsx: imported screen and waitFor; mocked @calcom/ui/components/toast.showToast; added tests verifying rejection for non-multiemail guests field and acceptance for multiemail. No public API signatures changed.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	The PR description clearly states the added guard in FormBuilder.handleSubmit for fields named "guests", the added translation key, and the new tests that mock showToast and verify rejection/acceptance; these points align with the raw summaries and therefore the description is related to the changeset. The level of detail is sufficient for this lenient check.
Title Check	✅ Passed	The title "fix: resolve 404 error when rescheduling seated event bookings due type mismatch" clearly references the reschedule/type-mismatch bug that the PR addresses and therefore is related to the changeset. The PR actually contains two related fixes — skipping frontend validation for existing responses during reschedule and disabling edits to the guests field for seated events — and the title highlights the reschedule 404 aspect but does not mention the UI restriction. Overall the title is specific and meaningful enough for a teammate to understand the primary bug being fixed.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch devin/1758308960-fix-reschedule-select-field-validation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
cal	Ignored			Sep 22, 2025 11:08am
cal-eu	Ignored			Sep 22, 2025 11:08am

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

packages/features/form-builder/FormBuilder.tsx (2)

383-387: Harden the "guests" check (normalize identifier).

Relying on exact equality can miss variants (whitespace/case). Normalize before comparing.

Apply this diff:

-            if (data.name === "guests" && type !== "multiemail") {
+            const normalizedName = String(data.name || "").trim().toLowerCase();
+            if (normalizedName === "guests" && type !== "multiemail") {
               showToast(t("guests_field_must_be_multiemail"), "error");
               return;
             }

---

957-957: Missing translation key used in tooltip.

t("Toggle Variant") appears to reference a non-existent key; it will fall back to the literal. Either add a key (e.g., toggle_variant) to locales or reuse an existing one.

packages/features/form-builder/FormBuilder.test.tsx (2)

8-9: Mocking toast is correct; clear between tests to avoid leakage.

Add a beforeEach(() => vi.clearAllMocks()) in this describe to isolate calls.

Apply this diff inside "Guests Field Validation Tests" describe:

 describe("Guests Field Validation Tests", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });

Also applies to: 37-39

---

280-314: Assertion on toast message may be brittle.

Tests assume t(k) === k. If localization changes to return real strings, this will fail. Prefer asserting toast was called with any string (or derive expected via t).

Example change:

-        expect(showToast).toHaveBeenCalledWith("guests_field_must_be_multiemail", "error");
+        expect(showToast).toHaveBeenCalledWith(expect.any(String), "error");

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c5942bc and bbad8ae.

📒 Files selected for processing (3)

• apps/web/public/static/locales/en/common.json (1 hunks)
• packages/features/form-builder/FormBuilder.test.tsx (3 hunks)
• packages/features/form-builder/FormBuilder.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

• packages/features/form-builder/FormBuilder.tsx
• packages/features/form-builder/FormBuilder.test.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

• packages/features/form-builder/FormBuilder.tsx
• packages/features/form-builder/FormBuilder.test.tsx

**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

• packages/features/form-builder/FormBuilder.tsx
• packages/features/form-builder/FormBuilder.test.tsx

🧠 Learnings (3)

📓 Common learnings

Learnt from: supalarry
PR: calcom/cal.com#23364
File: apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/internal-to-api.spec.ts:295-296
Timestamp: 2025-08-27T13:32:46.887Z
Learning: In calcom/cal.com, when transforming booking fields from internal to API format, tests in organizations-event-types.e2e-spec.ts already expect name field label and placeholder to be empty strings ("") rather than undefined. PR changes that set these to explicit empty strings are typically fixing implementation to match existing test expectations rather than breaking changes.

Learnt from: anglerfishlyy
PR: calcom/cal.com#0
File: :0-0
Timestamp: 2025-08-27T16:39:38.192Z
Learning: anglerfishlyy successfully implemented CAL-3076 email invitation feature for Cal.com team event-types in PR #23312. The feature allows inviting people via email directly from assignment flow, with automatic team invitation if email doesn't belong to existing team member. Implementation includes Host type modifications (userId?: number, email?: string, isPending?: boolean), CheckedTeamSelect component updates with CreatableSelect, TRPC schema validation with zod email validation, and integration with existing teamInvite system.

Learnt from: hariombalhara
PR: calcom/cal.com#23736
File: packages/features/bookings/lib/reschedule/determineReschedulePreventionRedirect.ts:73-84
Timestamp: 2025-09-12T11:23:34.158Z
Learning: In the Cal.com codebase, the forceRescheduleForCancelledBooking flag historically affects both CANCELLED and REJECTED booking statuses, despite its name suggesting it should only affect cancelled bookings. This behavior existed before PR #23736 and was preserved during the refactoring.

📚 Learning: 2025-08-29T22:57:30.382Z

Learnt from: bandhan-majumder
PR: calcom/cal.com#23454
File: packages/features/form-builder/FormBuilder.tsx:11-11
Timestamp: 2025-08-29T22:57:30.382Z
Learning: FormBuilder.tsx in packages/features/form-builder/ does not have "use client" directive at the top despite using client-side React hooks and event handlers, which suggests it should be a client component.

Applied to files:

• packages/features/form-builder/FormBuilder.tsx
• packages/features/form-builder/FormBuilder.test.tsx

📚 Learning: 2025-08-27T13:32:46.887Z

Learnt from: supalarry
PR: calcom/cal.com#23364
File: apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/internal-to-api.spec.ts:295-296
Timestamp: 2025-08-27T13:32:46.887Z
Learning: In calcom/cal.com, when transforming booking fields from internal to API format, tests in organizations-event-types.e2e-spec.ts already expect name field label and placeholder to be empty strings ("") rather than undefined. PR changes that set these to explicit empty strings are typically fixing implementation to match existing test expectations rather than breaking changes.

Applied to files:

• packages/features/form-builder/FormBuilder.test.tsx

🧬 Code graph analysis (1)

packages/features/form-builder/FormBuilder.test.tsx (1)

packages/features/form-builder/testUtils.ts (2)

• mockProps (18-26)
• pageObject (92-237)

🔇 Additional comments (2)

apps/web/public/static/locales/en/common.json (1)

2205-2205: LGTM: i18n key added for guests-type validation.

Key is correctly placed above the sentinel and used by the UI.

If you maintain non-English locales, consider adding this key there or confirm fallback-to-en is acceptable.

packages/features/form-builder/FormBuilder.test.tsx (1)

2-2: LGTM: waitFor import added for async assertions.

[github-actions]

E2E results are ready!

• Workflow #79580.1 latest results