fix: few more e2e flakes

[anikdhabal]

• In apps/web/playwright/fixtures/users.ts, the logout flow now locates the logout button by test ID, asserts its text is "Go back to the login page", reloads the page, and re-asserts the text.
• In apps/web/playwright/insights.e2e.ts, chart title selection was changed from substring matching to exact matching using a RegExp with ^ and $ anchors.

[coderabbitai]

Walkthrough

• In apps/web/playwright/fixtures/users.ts, the logout flow now locates the logout button by test ID, asserts its text is "Go back to the login page", reloads the page, and re-asserts the text.
• In apps/web/playwright/insights.e2e.ts, chart title selection was changed from substring matching to exact matching using a RegExp with ^ and $ anchors.
• No changes to exported/public API signatures.

Possibly related PRs

• fix: e2e flakes visible in ci #23897: Modifies apps/web/playwright/fixtures/users.ts to enhance the logout flow with post-navigation UI assertions similar to this change.
• feat: add e2e tests for insights charts #23777: Updates apps/web/playwright/insights.e2e.ts to adjust how chart title selectors are matched, aligning with the exact RegExp approach here.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	❓ Inconclusive	No author-provided PR description is present, so there is insufficient information to determine whether the changeset is adequately described; the raw_summary indicates e2e test fixes but the absence of an explicit description makes this check inconclusive.	Please add a short PR description that states the intent (e.g., reducing flaky e2e tests), lists the key files changed (apps/web/playwright/fixtures/users.ts and apps/web/playwright/insights.e2e.ts), and includes any verification steps or notes about what flakes were addressed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "fix: few more e2e flakes" clearly communicates the PR's intent to reduce end-to-end test flakiness and maps to the changes in the fixtures and insights e2e files (logout UI assertion and exact chart title matching), so it is on-topic and concise; however it is somewhat informal and could be more specific.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch flx-flaki-e2e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anikdhabal]

This one ensures that the session is correctly removed after logout. Previously it was causing flakes, as session were there

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

apps/web/playwright/insights.e2e.ts (1)

274-276: Escape dynamic regex input (future‑proof exact match).

new RegExp(\^${title}$`)` will misbehave if a future title contains regex metacharacters. It’s not a security risk here (constant array), but it can cause brittle tests and triggers linters.

Apply this diff and add a small helper:

-      const chartCard = page
-        .locator("[data-testid='panel-card'] h2")
-        .filter({ hasText: new RegExp(`^${title}$`) });
+      const chartCard = page
+        .locator("[data-testid='panel-card'] h2")
+        .filter({ hasText: new RegExp(`^${escapeRegex(title)}$`) });

Add once in this file (top-level is fine):

function escapeRegex(s: string) {
  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
}

apps/web/playwright/fixtures/users.ts (1)

687-691: LGTM. Minor hardening + DRY opportunity.

Solid flake guard. Optionally: assert URL after navigation and reuse the same assertion in both logout helpers to avoid drift.

-    logout: async () => {
-      await page.goto("/auth/logout");
-      const logoutBtn = page.getByTestId("logout-btn");
-      await expect(logoutBtn).toHaveText("Go back to the login page");
-      await page.reload();
-      await expect(logoutBtn).toHaveText("Go back to the login page");
-    },
+    logout: async () => {
+      await page.goto("/auth/logout");
+      await expect(page).toHaveURL(/\/auth\/logout$/);
+      await assertLogoutScreen(page);
+      await page.reload();
+      await assertLogoutScreen(page);
+    },

Add once in this file and reuse from the other logout (lines 585–591) too:

async function assertLogoutScreen(page: Page) {
  const logoutBtn = page.getByTestId("logout-btn");
  await expect(logoutBtn).toHaveText("Go back to the login page");
}

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d5d44fb and 980a5eb.

📒 Files selected for processing (2)

• apps/web/playwright/fixtures/users.ts (1 hunks)
• apps/web/playwright/insights.e2e.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

**/*.ts: For Prisma queries, only select data you need; never use include, always use select
Ensure the credential.key field is never returned from tRPC endpoints or APIs

Files:

• apps/web/playwright/fixtures/users.ts
• apps/web/playwright/insights.e2e.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

• apps/web/playwright/fixtures/users.ts
• apps/web/playwright/insights.e2e.ts

**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

• apps/web/playwright/fixtures/users.ts
• apps/web/playwright/insights.e2e.ts

🪛 ast-grep (0.39.5)

apps/web/playwright/insights.e2e.ts

[warning] 275-275: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(^${title}$)
Note: [CWE-1333] Inefficient Regular Expression Complexity [REFERENCES]
- https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS
- https://cwe.mitre.org/data/definitions/1333.html

(regexp-from-variable)

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Install dependencies / Yarn install & cache
• GitHub Check: Detect changes

[github-actions]

E2E results are ready!

• Workflow #79281.1 latest results

[Devanshusharma2005]

LGTM!