Skip to content

Comments

chore: remove atoms e2e for now#24085

Merged
emrysal merged 3 commits intomainfrom
remove-atoms-e2e
Sep 25, 2025
Merged

chore: remove atoms e2e for now#24085
emrysal merged 3 commits intomainfrom
remove-atoms-e2e

Conversation

@ThyMinimalDev
Copy link
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Sep 25, 2025 2:37pm
cal-eu Ignored Ignored Sep 25, 2025 2:37pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

This PR updates GitHub Actions workflows by removing the e2e-atoms job. In .github/workflows/all-checks.yml, the e2e-atoms job block is deleted and the required job’s needs list is updated to exclude it. In .github/workflows/pr.yml, the e2e-atoms job and all references (e.g., in merge-reports needs and final aggregation) are removed. No new jobs are added; changes are limited to deleting the job and adjusting dependencies.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description consists of generic template instructions and placeholder text without any mention of the actual removal of the e2e-atoms job. It does not describe any part of the changeset or provide context for the CI workflow updates. As such, it fails to meet even the lenient requirement for a relevant description. Please update the PR description to summarize the specific changes made, explicitly stating that the e2e-atoms job has been removed from the CI workflows and why this removal is necessary. Include any relevant context or rationale to help reviewers understand the impact of this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates that this change focuses on removing the atoms e2e workflow, which directly matches the main modification of deleting the e2e-atoms job in the CI configuration files. It is concise and follows conventional commit style with a “chore” prefix. The phrasing “for now” provides context that this removal is temporary but does not detract from clarity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-atoms-e2e

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8ed0fb6 and 7c1555b.

📒 Files selected for processing (2)
  • .github/workflows/all-checks.yml (1 hunks)
  • .github/workflows/pr.yml (2 hunks)
🔇 Additional comments (2)
.github/workflows/pr.yml (1)

205-209: Double-check merge-reports artifact expectations.

We’ve dropped e2e-atoms from the dependency graph, but please confirm .github/workflows/merge-reports.yml no longer tries to download or merge an e2e-atoms artifact; otherwise this job will start failing once the artifact stops being published.

.github/workflows/all-checks.yml (1)

78-78: Required aggregation list stays consistent

Dropping e2e-atoms from the required gate matches the job removal elsewhere, so the aggregation remains aligned and won’t wait on a now-missing workflow.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphite-app graphite-app bot requested a review from a team September 25, 2025 14:35
@keithwillcode keithwillcode added core area: core, team members only foundation platform Anything related to our platform plan labels Sep 25, 2025
@graphite-app graphite-app bot requested a review from a team September 25, 2025 14:35
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions labels Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

E2E results are ready!

@emrysal emrysal merged commit 7090e3e into main Sep 25, 2025
85 of 89 checks passed
@emrysal emrysal deleted the remove-atoms-e2e branch September 25, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions core area: core, team members only foundation platform Anything related to our platform plan ready-for-e2e size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants