Skip to content

Comments

chore: Migrate watchlist severity to Action#24195

Merged
alishaz-polymath merged 1 commit intomainfrom
chore/migrate-watchlist-severity
Oct 3, 2025
Merged

chore: Migrate watchlist severity to Action#24195
alishaz-polymath merged 1 commit intomainfrom
chore/migrate-watchlist-severity

Conversation

@alishaz-polymath
Copy link
Member

What does this PR do?

Update Watchlist.action to equal BLOCK where Watchlist.severity is CRITICAL, before we drop the WatchlistSeverity in the follow up migration/PR

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@alishaz-polymath alishaz-polymath marked this pull request as ready for review October 1, 2025 08:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

A new Prisma migration is added at packages/prisma/migrations/20250926134500_update_watchlist_action_block_for_critical_severity/migration.sql. The migration updates existing Watchlist rows by setting action to BLOCK where severity equals CRITICAL. No exported or public entity declarations are modified.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely captures the primary change of migrating the watchlist severity concept into the action field by updating the action based on severity, which directly reflects the purpose of the SQL migration included in the PR.
Description Check ✅ Passed The description explicitly explains updating Watchlist.action to BLOCK for entries with CRITICAL severity in preparation for dropping the WatchlistSeverity, directly matching the migration logic presented in the changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/migrate-watchlist-severity

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 43cc40d and d8e241f.

📒 Files selected for processing (1)
  • packages/prisma/migrations/20250926134500_update_watchlist_action_block_for_critical_severity/migration.sql (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Tests / Unit
  • GitHub Check: Linters / lint
  • GitHub Check: Type check / check-types
🔇 Additional comments (1)
packages/prisma/migrations/20250926134500_update_watchlist_action_block_for_critical_severity/migration.sql (1)

1-4: LGTM – keeps data consistent ahead of severity removal.

The update cleanly enforces the intended mapping without side effects.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alishaz-polymath alishaz-polymath requested a review from a team as a code owner October 1, 2025 08:07
@github-actions github-actions bot added the ❗️ migrations contains migration files label Oct 1, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

E2E results are ready!

@alishaz-polymath alishaz-polymath merged commit 60e3244 into main Oct 3, 2025
80 of 84 checks passed
@alishaz-polymath alishaz-polymath deleted the chore/migrate-watchlist-severity branch October 3, 2025 07:18
@coderabbitai coderabbitai bot mentioned this pull request Oct 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ❗️ migrations contains migration files ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants