Skip to content

Comments

refactor: fail breaking change check on error only#24221

Merged
supalarry merged 2 commits intomainfrom
refactor-turn-off-warn-level-breaking-checks
Oct 2, 2025
Merged

refactor: fail breaking change check on error only#24221
supalarry merged 2 commits intomainfrom
refactor-turn-off-warn-level-breaking-checks

Conversation

@supalarry
Copy link
Contributor

WARN level is too picky so we only fail breaking change check on ERR level

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

The workflow file .github/workflows/e2e-api-v2.yml updates the oasdiff breaking-change check configuration. In the "Check breaking changes" step, the fail-on parameter is changed from WARN to ERR in the breakdown step comparing base and revision OpenAPI specs. This alters control flow so that detected breaking changes cause the workflow to fail instead of continuing with warnings. No exported or public entities are changed.

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change by indicating that the breaking change check will now fail only on error level, which directly reflects the workflow modification in the changeset.
Description Check ✅ Passed The description clearly explains that WARN-level results are too strict and that only ERR-level breaking change checks will cause failures, which directly corresponds to the adjustments made in the workflow.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor-turn-off-warn-level-breaking-checks

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 96468c4 and 4416e54.

📒 Files selected for processing (1)
  • .github/workflows/e2e-api-v2.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Install dependencies / Yarn install & cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphite-app graphite-app bot requested a review from a team October 2, 2025 12:30
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Oct 2, 2025
@supalarry supalarry requested review from ThyMinimalDev and removed request for a team October 2, 2025 12:30
@supalarry supalarry enabled auto-merge (squash) October 2, 2025 12:30
@graphite-app graphite-app bot requested a review from a team October 2, 2025 12:30
@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Oct 2, 2025 0:47am
cal-eu Ignored Ignored Oct 2, 2025 0:47am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

E2E results are ready!

@supalarry supalarry merged commit 6b7d22d into main Oct 2, 2025
60 of 62 checks passed
@supalarry supalarry deleted the refactor-turn-off-warn-level-breaking-checks branch October 2, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only platform Anything related to our platform plan ready-for-e2e 💻 refactor size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants