fix: event is not added to outlook cal through workflow ics file

[anikdhabal]

What does this PR do?

event is not added to outlook cal through workflow ics file

[coderabbitai]

Walkthrough

The change updates ICS calendar attachment metadata across three modules. In packages/emails/lib/generateIcsFile.ts, the returned attachment no longer includes type and disposition fields; a method: "REQUEST" field is introduced. In packages/features/ee/workflows/api/scheduleEmailReminders.ts and packages/features/ee/workflows/lib/reminders/emailReminderManager.ts, attachment objects drop type, disposition, and contentId, keeping only method: "REQUEST". Control flow and other fields remain unchanged. No exported/public API changes are declared.

Possibly related PRs

• chore: add content type to ics file #24069: Modifies generateIcsFile.ts in the opposite way (replacing method with type/disposition), directly conflicting with this attachment metadata change.
• fix: workflows attach ICS file in base64 format  #23680: Alters ICS attachment handling and encoding in scheduleEmailReminders.ts and emailReminderManager.ts, overlapping the same files and attachment logic.
• fix: ICS file on workflows where the invite is added wont display the link of the integration #22964: Adjusts ICS/email attachment generation in emailReminderManager.ts, intersecting with this PR’s changes to attachment structure.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title concisely captures the primary change of fixing events not being added to the Outlook calendar via the workflow ICS file and directly corresponds to the adjustments made in the pull request.
Description Check	✅ Passed	The pull request description identifies the specific issue—events not being added to Outlook calendars via the workflow ICS file—and directly relates to the changes in ICS attachment metadata shown in the diff, so it passes the relevance criteria despite its brevity.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ics-file0fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/features/ee/workflows/api/scheduleEmailReminders.ts (1)

1-3: Consider documenting the migration timeline.

This file is marked as deprecated in favor of SMTP with tasker. Consider adding a comment about when this deprecated code will be removed and ensuring the replacement implementation includes the same Outlook ICS fix.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b92c86 and 839a0b6.

📒 Files selected for processing (3)

• packages/emails/lib/generateIcsFile.ts (1 hunks)
• packages/features/ee/workflows/api/scheduleEmailReminders.ts (1 hunks)
• packages/features/ee/workflows/lib/reminders/emailReminderManager.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

**/*.ts: For Prisma queries, only select data you need; never use include, always use select
Ensure the credential.key field is never returned from tRPC endpoints or APIs

Files:

• packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
• packages/emails/lib/generateIcsFile.ts
• packages/features/ee/workflows/api/scheduleEmailReminders.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

• packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
• packages/emails/lib/generateIcsFile.ts
• packages/features/ee/workflows/api/scheduleEmailReminders.ts

**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

• packages/features/ee/workflows/lib/reminders/emailReminderManager.ts
• packages/emails/lib/generateIcsFile.ts
• packages/features/ee/workflows/api/scheduleEmailReminders.ts

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Install dependencies / Yarn install & cache

🔇 Additional comments (3)

packages/features/ee/workflows/lib/reminders/emailReminderManager.ts (1)

251-263: LGTM! Attachment structure is consistent with the fix.

The simplified attachment structure aligns with the changes in generateIcsFile.ts, removing explicit MIME metadata in favor of the method: "REQUEST" field. This should help Outlook properly recognize the ICS file as a calendar event.

packages/features/ee/workflows/api/scheduleEmailReminders.ts (1)

344-352: LGTM – ICS attachments with method: "REQUEST" are forwarded in both SendGrid and SMTP pathways.

packages/emails/lib/generateIcsFile.ts (1)

32-40: Rely on Nodemailer’s icalEvent option for RFC-compliant text/calendar;method=REQUEST—no manual MIME metadata needed.

[github-actions]

E2E results are ready!

• Workflow #81674.1 latest results